Migrate dn-bot-dnceng-workitems-rw to Managed Identity (WI 10135)#6480
Open
missymessa wants to merge 9 commits intomainfrom
Open
Migrate dn-bot-dnceng-workitems-rw to Managed Identity (WI 10135)#6480missymessa wants to merge 9 commits intomainfrom
missymessa wants to merge 9 commits intomainfrom
Conversation
The AzureDevOpsClient shared library already supports MI auth via ManagedIdentityClientId. This change is config-only: - settings.json: Remove [vault(dn-bot-dnceng-workitems-rw)] from AzureDevOps:dnceng - settings.Production.json: Add AzureDevOps:dnceng:ManagedIdentityClientId (d2580e46-...) - settings.Staging.json: Add AzureDevOps:dnceng:ManagedIdentityClientId (e9d81917-...) - dotneteng-status-secrets.yaml: Remove dn-bot-dnceng-workitems-rw vault entry The AzureDevOpsClient constructor already: 1. Prefers AccessToken (PAT) if present 2. Falls back to ManagedIdentityCredential if ManagedIdentityClientId is set 3. Uses the AzDO resource scope (499b84ac-.../default) for bearer tokens
garath
reviewed
Mar 26, 2026
garath
reviewed
Mar 26, 2026
src/DotNet.Status.Web/DotNet.Status.Web/.config/settings.Production.json
Outdated
Show resolved
Hide resolved
garath
reviewed
Mar 26, 2026
src/DotNet.Status.Web/DotNet.Status.Web/.config/settings.Production.json
Outdated
Show resolved
Hide resolved
garath
reviewed
Mar 26, 2026
src/DotNet.Status.Web/DotNet.Status.Web/.config/settings.Staging.json
Outdated
Show resolved
Hide resolved
1. Remove leftover comment from dotneteng-status-secrets.yaml (garath) 2. Replace wrong helix-cluster MI client IDs with UseManagedIdentity flag - Production and Staging settings now use 'UseManagedIdentity: true' - System-assigned MIs don't need a client ID (garath) 3. Add UseManagedIdentity bool to AzureDevOpsClientOptions - When true without ManagedIdentityClientId: system-assigned MI - When true with ManagedIdentityClientId: user-assigned MI 4. Split bearer auth test into user-assigned and system-assigned cases 5. Remove placeholder client IDs from post-deployment tests
garath
previously approved these changes
Mar 30, 2026
The AzureDevOpsTimeline class implemented IServiceImplementation from Microsoft.DotNet.ServiceFabric.ServiceHost, which ships as an x64-only assembly. This caused FileNotFoundException / BadImageFormatException on ARM64 machines (and potentially in CI if pool architecture changed). Extract the business logic into AzureDevOpsTimelineProcessor (no SF dependency) and reduce AzureDevOpsTimeline to a thin Service Fabric wrapper. Tests now target the processor directly and no longer trigger the ServiceHost assembly load. All 11 AzureDevOpsTimeline tests now pass on both ARM64 and x64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate the \dn-bot-dnceng-workitems-rw\ PAT (work_write scope, dnceng org) to Managed Identity in DotNet.Status.Web. The \AzureDevOpsClient\ shared library already supports MI auth via \ManagedIdentityClientId\ — this is a config-only change.
Changes (4 files)
How it works
The \AzureDevOpsClient\ constructor (in src/Telemetry/AzureDevOpsClient/) already has MI support:
By removing the vault reference and adding per-env MI client IDs, the client will automatically use MI auth in staging/production.
Related: AB#10135