-
Notifications
You must be signed in to change notification settings - Fork 382
[main] Source code updates from dotnet/dotnet #5518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Source code updates from dotnet/dotnet #5518
Conversation
Updated Dependencies: Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis (Version 10.0.0-beta.25351.106 -> 10.0.0-beta.25358.102) Microsoft.NET.Sdk (Version 10.0.100-preview.7.25351.106 -> 10.0.100-preview.7.25358.102) Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.App.Ref, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms (Version 10.0.0-preview.7.25351.106 -> 10.0.0-preview.7.25358.102) Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.Analyzers (Version 5.0.0-1.25351.106 -> 5.0.0-1.25358.102) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25351.106 -> 10.0.0-preview.25358.102)
cc @hoyosjs |
Could the recent SDK changes around RID specific tools be related? cc @dsplaisted @baronfel |
Most likely - we do set rids. I have to check how this changes it. |
Updated Dependencies: Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis (Version 10.0.0-beta.25358.102 -> 10.0.0-beta.25359.101) Microsoft.NET.Sdk (Version 10.0.100-preview.7.25358.102 -> 10.0.100-preview.7.25359.101) Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.App.Ref, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms (Version 10.0.0-preview.7.25358.102 -> 10.0.0-preview.7.25359.101) Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.Analyzers (Version 5.0.0-1.25358.102 -> 5.0.0-1.25359.101) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25358.102 -> 10.0.0-preview.25359.101)
Updated Dependencies: Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis (Version 10.0.0-beta.25359.101 -> 10.0.0-beta.25360.101) Microsoft.NET.Sdk (Version 10.0.100-preview.7.25359.101 -> 10.0.100-preview.7.25360.101) Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.App.Ref, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms (Version 10.0.0-preview.7.25359.101 -> 10.0.0-preview.7.25360.101) Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.Analyzers (Version 5.0.0-1.25359.101 -> 5.0.0-1.25360.101) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25359.101 -> 10.0.0-preview.25360.101)
[[ commit created by automation ]]
Updated Dependencies: Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis (Version 10.0.0-beta.25360.101 -> 10.0.0-beta.25362.103) Microsoft.NET.Sdk (Version 10.0.100-preview.7.25360.101 -> 10.0.100-preview.7.25362.103) Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.App.Ref, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms (Version 10.0.0-preview.7.25360.101 -> 10.0.0-preview.7.25362.103) Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.Analyzers (Version 5.0.0-1.25360.101 -> 5.0.0-1.25362.103) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25360.101 -> 10.0.0-preview.25362.103)
[[ commit created by automation ]]
Updated Dependencies: Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis (Version 10.0.0-beta.25362.103 -> 10.0.0-beta.25363.101) Microsoft.NET.Sdk (Version 10.0.100-preview.7.25362.103 -> 10.0.100-preview.7.25363.101) Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.App.Ref, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms (Version 10.0.0-preview.7.25362.103 -> 10.0.0-preview.7.25363.101) Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.Analyzers (Version 5.0.0-1.25362.103 -> 5.0.0-1.25363.101) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25362.103 -> 10.0.0-preview.25363.101)
Updated Dependencies: Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis (Version 10.0.0-beta.25363.101 -> 10.0.0-beta.25364.102) Microsoft.NET.Sdk (Version 10.0.100-preview.7.25363.101 -> 10.0.100-preview.7.25364.102) Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.App.Ref, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms (Version 10.0.0-preview.7.25363.101 -> 10.0.0-preview.7.25364.102) Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.Analyzers (Version 5.0.0-1.25363.101 -> 5.0.0-1.25364.102) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25363.101 -> 10.0.0-preview.25364.102)
Updated Dependencies: Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis (Version 10.0.0-beta.25364.102 -> 10.0.0-beta.25365.101) Microsoft.NET.Sdk (Version 10.0.100-preview.7.25364.102 -> 10.0.100-preview.7.25365.101) Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.App.Ref, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms (Version 10.0.0-preview.7.25364.102 -> 10.0.0-preview.7.25365.101) Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.Analyzers (Version 5.0.0-1.25364.102 -> 5.0.0-1.25365.101) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25364.102 -> 10.0.0-preview.25365.101)
eng/Version.Details.xml
Outdated
<Uri>https://github.com/dotnet/dotnet</Uri> | ||
<Sha>eaa19c281d34580a8168cff9ce1e7337da8bfe4f</Sha> | ||
<Sha>78061f4bcc414fa2054be6237b1fd3813d8edf6b</Sha> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ViktorHofer - this changes code from system.commandline but doesn't bump the dep. This is pretty painful for backflows... Essentially we either agree we want to use the VMR version of commandline (which is a business decision and would be good to consult the team), or you leave the version fixed and no code change is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bumping also needs #5493
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamsitnik - I folded the changes for public types here, but there's still seems to be no way to set the help width from the helpaction. Is there a planned API on this? I don't want to regress that scenario.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamsitnik - I folded the changes for public types here, but there's still seems to be no way to set the help width from the helpaction. Is there a planned API on this? I don't want to regress that scenario.
I've sent dotnet/command-line-api#2635. Once it gets merged you should be able to achieve the same effect with the new API. Apologies for the delay
… and react to changes in the library Co-authored-by: Adam Sitnik <[email protected]>
The duplicates are the shims: artifacts\bin\dotnet-dump\Debug/shims/net8.0\win-x64\dotnet-dump.exe The one coming from ComputeEmbeddedApphostPaths-> GetEmbeddedApphostPaths not normalizing This was the normalization that made one path correct but not the other: Wonder if normalizing |
That worked for dotnet-dump so I opened dotnet/sdk#49801 |
sdk flow is currently blocked on dotnet/dotnet#1475 |
[[ commit created by automation ]]
Updated Dependencies: Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis (Version 10.0.0-beta.25365.101 -> 10.0.0-beta.25366.103) Microsoft.NET.Sdk (Version 10.0.100-preview.7.25365.101 -> 10.0.100-preview.7.25366.103) Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.App.Ref, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms (Version 10.0.0-preview.7.25365.101 -> 10.0.0-preview.7.25366.103) Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.Analyzers (Version 5.0.0-1.25365.101 -> 5.0.0-1.25366.103) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25365.101 -> 10.0.0-preview.25366.103)
I'll revert System.Commandline changes - we've decided to pin the dependency |
@hoyosjs I don't think that will work given source-build will be using the live version |
@akoeplinger - we don't ship out of VMR/sourcebuild. There's exactly 1 thing that is considered as a supported asset from diagnostics for the VMR: |
Updated Dependencies: Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis (Version 10.0.0-beta.25366.103 -> 10.0.0-beta.25367.101) Microsoft.NET.Sdk (Version 10.0.100-preview.7.25366.103 -> 10.0.100-preview.7.25367.101) Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.App.Ref, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms (Version 10.0.0-preview.7.25366.103 -> 10.0.0-preview.7.25367.101) Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.Analyzers (Version 5.0.0-1.25366.103 -> 5.0.0-2.25367.101) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25366.103 -> 10.0.0-preview.25367.101)
Updated Dependencies: runtime.win-x64.Microsoft.DotNet.Cdac.Transport, runtime.win-arm64.Microsoft.DotNet.Cdac.Transport, runtime.linux-x64.Microsoft.DotNet.Cdac.Transport, runtime.linux-arm64.Microsoft.DotNet.Cdac.Transport, runtime.osx-x64.Microsoft.DotNet.Cdac.Transport, runtime.osx-arm64.Microsoft.DotNet.Cdac.Transport (Version 10.0.0-preview.7.25351.106 -> 10.0.0-preview.7.25367.104) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis (Version 10.0.0-beta.25367.101 -> 10.0.0-beta.25367.104) Microsoft.NET.Sdk (Version 10.0.100-preview.7.25367.101 -> 10.0.100-preview.7.25367.104) Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.App.Ref, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms (Version 10.0.0-preview.7.25367.101 -> 10.0.0-preview.7.25367.104) Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.Analyzers (Version 5.0.0-2.25367.101 -> 5.0.0-2.25367.104) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25367.101 -> 10.0.0-preview.25367.104)
Updated Dependencies: runtime.linux-arm64.Microsoft.DotNet.Cdac.Transport, runtime.linux-x64.Microsoft.DotNet.Cdac.Transport, runtime.osx-arm64.Microsoft.DotNet.Cdac.Transport, runtime.osx-x64.Microsoft.DotNet.Cdac.Transport, runtime.win-arm64.Microsoft.DotNet.Cdac.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, runtime.win-x64.Microsoft.DotNet.Cdac.Transport (Version 10.0.0-preview.7.25374.102 -> 10.0.0-preview.7.25375.106) Microsoft.AspNetCore.App.Ref, Microsoft.AspNetCore.App.Ref.Internal (Version 10.0.0-rc.1.25374.102 -> 10.0.0-rc.1.25375.106) Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp (Version 5.0.0-2.25374.102 -> 5.0.0-2.25375.106) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25374.102 -> 10.0.0-preview.25375.106) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis (Version 10.0.0-beta.25374.102 -> 10.0.0-beta.25375.106) Microsoft.NET.Sdk (Version 10.0.100-preview.7.25374.102 -> 10.0.100-preview.7.25375.106)
8c8904d
This reverts commit 0321073.
Updated Dependencies: runtime.linux-arm64.Microsoft.DotNet.Cdac.Transport, runtime.linux-x64.Microsoft.DotNet.Cdac.Transport, runtime.osx-arm64.Microsoft.DotNet.Cdac.Transport, runtime.osx-x64.Microsoft.DotNet.Cdac.Transport, runtime.win-arm64.Microsoft.DotNet.Cdac.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, runtime.win-x64.Microsoft.DotNet.Cdac.Transport (Version 10.0.0-preview.7.25375.106 -> 10.0.0-preview.7.25375.119) Microsoft.AspNetCore.App.Ref, Microsoft.AspNetCore.App.Ref.Internal (Version 10.0.0-rc.1.25375.106 -> 10.0.0-rc.1.25375.119) Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp (Version 5.0.0-2.25375.106 -> 5.0.0-2.25375.119) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25375.106 -> 10.0.0-preview.25375.119) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis (Version 10.0.0-beta.25375.106 -> 10.0.0-beta.25375.119) Microsoft.NET.Sdk (Version 10.0.100-preview.7.25375.106 -> 10.0.100-preview.7.25375.119)
[[ commit created by automation ]]
Updated Dependencies: runtime.linux-arm64.Microsoft.DotNet.Cdac.Transport, runtime.linux-x64.Microsoft.DotNet.Cdac.Transport, runtime.osx-arm64.Microsoft.DotNet.Cdac.Transport, runtime.osx-x64.Microsoft.DotNet.Cdac.Transport, runtime.win-arm64.Microsoft.DotNet.Cdac.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, runtime.win-x64.Microsoft.DotNet.Cdac.Transport (Version 10.0.0-preview.7.25375.119 -> 10.0.0-preview.7.25377.103) Microsoft.AspNetCore.App.Ref, Microsoft.AspNetCore.App.Ref.Internal (Version 10.0.0-rc.1.25375.119 -> 10.0.0-rc.1.25377.103) Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp (Version 5.0.0-2.25375.119 -> 5.0.0-2.25377.103) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25375.119 -> 10.0.0-preview.25377.103) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis (Version 10.0.0-beta.25375.119 -> 10.0.0-beta.25377.103) Microsoft.NET.Sdk (Version 10.0.100-preview.7.25375.119 -> 10.0.100-preview.7.25377.103)
[[ commit created by automation ]]
Updated Dependencies: runtime.linux-arm64.Microsoft.DotNet.Cdac.Transport, runtime.linux-x64.Microsoft.DotNet.Cdac.Transport, runtime.osx-arm64.Microsoft.DotNet.Cdac.Transport, runtime.osx-x64.Microsoft.DotNet.Cdac.Transport, runtime.win-arm64.Microsoft.DotNet.Cdac.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, runtime.win-x64.Microsoft.DotNet.Cdac.Transport (Version 10.0.0-preview.7.25377.103 -> 10.0.0-rc.1.25401.103) Microsoft.AspNetCore.App.Ref, Microsoft.AspNetCore.App.Ref.Internal (Version 10.0.0-rc.1.25377.103 -> 10.0.0-rc.1.25401.103) Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp (Version 5.0.0-2.25377.103 -> 5.0.0-2.25401.103) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25377.103 -> 10.0.0-preview.25401.103) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis (Version 10.0.0-beta.25377.103 -> 10.0.0-beta.25401.103) Microsoft.NET.Sdk (Version 10.0.100-preview.7.25377.103 -> 10.0.100-rc.1.25401.103) Microsoft.Diagnostics.Runtime, Microsoft.Diagnostics.Runtime.Utilities (Version 4.0.0-beta.25381.2 -> 4.0.0-beta.25381.2)
This reverts commit 0321073.
I disabled the subscription for now so we don't need to constantly do the revert. This still fails due to the test failure on Windows x86. I think we should disable the test to unblock the PR. |
Gentle ping @hoyosjs. We want to get this one in before the snap on Friday. |
Otherwise this will point to the path in the executing host sdk which causes issues when running x86 tests.
Note
This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
New Dependencies
Updated Dependencies
Associated changes in source repos