[main] Source code updates from dotnet/dotnet#65987
Conversation
[[ commit created by automation ]]
Updated Dependencies: Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.NETCore.BrowserDebugHost.Transport, Microsoft.NET.Runtime.MonoAOTCompiler.Task, dotnet-ef, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Http, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Options, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, System.Collections.Immutable, System.Composition, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.Diagnostics.PerformanceCounter, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Hashing, System.IO.Pipelines, System.Memory.Data, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Numerics.Tensors, System.Reflection.Metadata, System.Resources.Extensions, System.Runtime.Caching, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting (Version 11.0.0-preview.3.26153.117 -> 11.0.0-preview.3.26176.106) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 11.0.0-beta.26153.117 -> 11.0.0-beta.26176.106) Microsoft.Web.Xdt (Version 3.3.0-preview.3.26153.117 -> 3.3.0-preview.3.26176.106) NuGet.Frameworks, NuGet.Packaging, NuGet.Versioning (Version 7.5.0-rc.15417 -> 7.6.0-rc.17706) [[ commit created by automation ]]
Run eng/scripts/GenerateProjectList.ps1 to update generated props files after codeflow source changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use .Value instead of direct cast from nullable KeyValuePair to non-nullable, which is now a warning-as-error with the updated compiler from the codeflow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This reverts commit 341c0c1.
This reverts commit 14fb2e5.
|
I think dotnet/runtime#125365 broke us |
|
Important While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged). You can continue with one of the following options:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
Should be good now, hopefully |
|
cc @agocke |
|
CC @sbomer as well, I've tried a few different approaches to getting |
|
🤖 🤖 The 26176+ ILLink NuGet package ( In the SDK, the test itself was adding: <TrimmerRootAssembly Include="@(IntermediateAssembly->'%(FullPath)')" />Changing to The aspnetcore shared fx build may have similar custom |
|
🤖 🤖 runtime#125365 removed the This is likely a regression in runtime#125365's change to |
|
If I'm not missing anything, the assembly root problem is fixed here right? The change to pass assembly names as
They just need to be passed as |
…hange %(FileName) on a dotted assembly name like 'Microsoft.AspNetCore.Components' strips the last segment as a file extension, producing 'Microsoft.AspNetCore' instead of the full name. Use %(Identity) which preserves the complete name.
|
Looks like the trim warnings were related (the RootAssemblyNames fix caused us to pass the wrong filename for some xml suppressions) - pushed a fix. |
Note
This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Updated Dependencies
Associated changes in source repos
Diff the source with this PR branch