Repository navigation
IHttpRequestBodyDetectionFeature for HTTP/3 GET requests - #62275
Merged
Merged
Conversation
- Updated `IHttpRequestBodyDetectionFeature` to include HTTP/3 descriptions for the `END_STREAM` flag. - Modified request body handling logic to return zero length content body instance when there endstream flag is set. It also completes the message body for empty requests, so that the RequestBodyPipe.Reader is closed (needed when stream is reused by the pool and the Pipe is reset). - Added unit test `CanHaveBody_ReturnsFalseWithoutRequestBody` to validate behavior when no request body is present.
ladeak
requested review from
BrennanConroy,
JamesNK,
captainsafia,
halter73 and
mgravell
as code owners
June 7, 2025 07:51
github-actions
Bot
added
the
area-networking
dotnet-policy-service
Bot
added
the
community-contribution
Member
|
Contributor
Author
|
@BrennanConroy - I will follow up on that. |
ladeak
marked this pull request as draft
June 10, 2025 06:25
…der was not closed in http3) causing Reset to throw when stream was re-used.
ladeak
marked this pull request as ready for review
June 10, 2025 20:46
Contributor
Author
|
@BrennanConroy I addressed your concern. |
dotnet-policy-service
Bot
added
the
pending-ci-rerun
Contributor
Author
|
@BrennanConroy could you review the changes? |
BrennanConroy
approved these changes
Jul 1, 2025
Co-authored-by: Brennan <brecon@microsoft.com>
Co-authored-by: Brennan <brecon@microsoft.com>
BrennanConroy
removed
the
pending-ci-rerun
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IHttpRequestBodyDetectionFeaturefor HTTP/3 GET requestsIHttpRequestBodyDetectionFeaturereturns false for HTTP/3 (bodyless) GET requestsDescription
IHttpRequestBodyDetectionFeatureto include HTTP/3 descriptions for theEND_STREAMflag.Http3Streammodified request body handling logic to return zero length content body instance when there endstream flag is set. It also completes the message body for empty requests, so that theRequestBodyPipe.Readeris closed (needs to be closed, so that when the stream is reused by the pool, the Pipe is reset which requires closed reader) - not sure if this is the best place to do this.CanHaveBody_ReturnsFalseWithoutRequestBodyto validate behavior when no request body is present.Fixes #58753