[release/7.0] Support populating cache without serving from it. #47481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
Tratcher and
BrennanConroy
as code owners
ghost
added
|
Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
mitchdenny
added
the
Servicing-consider
|
Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
adityamandaleeka
approved these changes
Mar 29, 2023
amcasey
added
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #47392 to release/7.0
/cc @mitchdenny
Support populating cache without serving from it.
Description
At the moment if a developer sets
AllowCacheLookuptofalsebutAllowCacheStoragetotruethe output caching middlewhere will throw a null reference exception which is obviously not intended. The problem stems from the fact that the cache key that cache storage relies on is a side effect of looking up the cache. This change simply makes it so that the cache key is created even if justAllowCacheStorageis enabled.This is a useful scenario because someone might want to implement a cache refresh mechanism which forces to repopulation of the cache without attempting to first fetch what might be considered stale data. The test case in this PR illustrates this scenario.
Fixes #46671
Customer Impact
{Justification}
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
We are just calling
CreateCacheKeya second time. If the key is already created the method no-ops - so this just enables the scenario mentioned above.Verification
Packaging changes reviewed?
When servicing release/2.1