-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[release/7.0] Web.ProjectTemplates: exclude 'Program.cs' from all templates that replace it. #47114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, although do we want this in for the next servicing release?
Yep, missed the cut-off for the last release. |
We expect to merge this in early April (when branches open), right? |
Yep, I'll send the servicing request for it at that time as well. |
@captainsafia can you get servicing approval for this? |
I was OOF during the first couple of days of the servicing window. I'll see if I can get approval by 4/10 for this. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@tmds What's the best way to verify this change manually? I'm not sure how to reproduce the bug in the current version of 7.0 to verify that we fixed the behavior here... |
@captainsafia this reproduced always on our CI server and, I think, on my machine as well. I don't know how you can make it reproduce on an environment where it is not reproducing by default. If you want, I can see if the 7.0 branch reproduces this issue on my machine before this patch, and after. Anyway, the template experts (that chimed in on the PR) confirmed the behavior was not deterministic the way it was previously defined. |
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
I followed up with @vlada-shubina about this. Considering it happens on certain flavors of Linux and hasn't been reproduced outside of CI, it isn't worth taking through tactics for servicing at this moment. |
Backport of #46769 to release/7.0
/cc @captainsafia @tmds
Web.ProjectTemplates: exclude 'Program.cs' from all templates that replace it.
Summary of the changes (Less than 80 chars)
Description
{Detail}
Fixes #{bug number} (in this specific format)
Customer Impact
{Justification}
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
When servicing release/2.1