Skip to content

[release/7.0] Web.ProjectTemplates: exclude 'Program.cs' from all templates that replace it. #47114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 9, 2023

Backport of #46769 to release/7.0

/cc @captainsafia @tmds

Web.ProjectTemplates: exclude 'Program.cs' from all templates that replace it.

Summary of the changes (Less than 80 chars)

Description

{Detail}

Fixes #{bug number} (in this specific format)

Customer Impact

{Justification}

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

When servicing release/2.1

  • Make necessary changes in eng/PatchConfig.props

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Mar 9, 2023
@ghost ghost added this to the 7.0.x milestone Mar 9, 2023
@ghost
Copy link

ghost commented Mar 9, 2023

Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@ghost
Copy link

ghost commented Mar 17, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please leave an /azp run comment here to rerun the CI pipeline and confirm success before merging the change.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Mar 17, 2023
Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, although do we want this in for the next servicing release?

@captainsafia
Copy link
Member

Approved, although do we want this in for the next servicing release?

Yep, missed the cut-off for the last release.

@RussKie
Copy link
Contributor

RussKie commented Mar 22, 2023

We expect to merge this in early April (when branches open), right?

@captainsafia
Copy link
Member

We expect to merge this in early April (when branches open), right?

Yep, I'll send the servicing request for it at that time as well.

@wtgodbe
Copy link
Member

wtgodbe commented Apr 4, 2023

@captainsafia can you get servicing approval for this?

@captainsafia
Copy link
Member

@captainsafia can you get servicing approval for this?

I was OOF during the first couple of days of the servicing window. I'll see if I can get approval by 4/10 for this.

@captainsafia
Copy link
Member

/azp run

@ghost ghost removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Apr 10, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@captainsafia
Copy link
Member

@tmds What's the best way to verify this change manually? I'm not sure how to reproduce the bug in the current version of 7.0 to verify that we fixed the behavior here...

@tmds
Copy link
Member

tmds commented Apr 13, 2023

@captainsafia this reproduced always on our CI server and, I think, on my machine as well. I don't know how you can make it reproduce on an environment where it is not reproducing by default.

If you want, I can see if the 7.0 branch reproduces this issue on my machine before this patch, and after.

Anyway, the template experts (that chimed in on the PR) confirmed the behavior was not deterministic the way it was previously defined.

@ghost
Copy link

ghost commented Apr 21, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please leave an /azp run comment here to rerun the CI pipeline and confirm success before merging the change.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Apr 21, 2023
@captainsafia
Copy link
Member

/azp run

@ghost ghost removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Apr 21, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@ghost
Copy link

ghost commented Apr 29, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please leave an /azp run comment here to rerun the CI pipeline and confirm success before merging the change.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Apr 29, 2023
@captainsafia
Copy link
Member

@captainsafia this reproduced always on our CI server and, I think, on my machine as well. I don't know how you can make it reproduce on an environment where it is not reproducing by default.

If you want, I can see if the 7.0 branch reproduces this issue on my machine before this patch, and after.

Anyway, the template experts (that chimed in on the PR) confirmed the behavior was not deterministic the way it was previously defined.

I followed up with @vlada-shubina about this. Considering it happens on certain flavors of Linux and hasn't been reproduced outside of CI, it isn't worth taking through tactics for servicing at this moment.

@wtgodbe wtgodbe deleted the backport/pr-46769-to-release/7.0 branch November 15, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants