-
Notifications
You must be signed in to change notification settings - Fork 375
Remove PublishWindowsPdb & ConvertPortablePdbsToWindowsPdbs switches #15736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@hoyosjs should the parts of https://github.com/dotnet/arcade/tree/main/src/Microsoft.DotNet.Internal.SymbolHelper that deal with pdb conversion be removed as well? |
I pushed that removal, let us know if it's still needed |
Last I checked, the gate still required it |
the gate? You mean the stargate? 😌 |
Insertion gates. Just a few months ago insertions would fail without conversion. |
VS shouldn't require Windows PDBs anymore. Roslyn doesn't produce them anymore (see the linked issue). Do you know to whom I can reach out to discuss this requirement? cc @marcpopMSFT |
Fixes #15724
Fixes dotnet/dotnet#1017
To double check: