Skip to content

Remove PublishWindowsPdb & ConvertPortablePdbsToWindowsPdbs switches #15736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Apr 14, 2025

Fixes #15724
Fixes dotnet/dotnet#1017

To double check:

akoeplinger
akoeplinger previously approved these changes Apr 14, 2025
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Apr 14, 2025

@hoyosjs should the parts of https://github.com/dotnet/arcade/tree/main/src/Microsoft.DotNet.Internal.SymbolHelper that deal with pdb conversion be removed as well?

@ViktorHofer ViktorHofer requested a review from hoyosjs April 14, 2025 15:15
@akoeplinger
Copy link
Member

I pushed that removal, let us know if it's still needed

@hoyosjs
Copy link
Member

hoyosjs commented Apr 14, 2025

Last I checked, the gate still required it

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Apr 14, 2025

the gate?

You mean the stargate? 😌

@hoyosjs
Copy link
Member

hoyosjs commented Apr 14, 2025

Insertion gates. Just a few months ago insertions would fail without conversion.

@ViktorHofer
Copy link
Member Author

VS shouldn't require Windows PDBs anymore. Roslyn doesn't produce them anymore (see the linked issue). Do you know to whom I can reach out to discuss this requirement? cc @marcpopMSFT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake test build projects pick up Arcade SDK Remove Windows PDB conversion
3 participants