Don't take package metadata into account when computing nupkg filename. #15023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nupkg filenames don't contain the metadata from the package version, so compute filenames without the metadata. This naming behavior can be tested like this: ```shell $ mkdir nupkgtest && cd nupkgtest $ dotnet new classlib [...] $ dotnet pack -p:PackageVersion=3.14 [...] $ ls **/*.nupkg bin/Release/nupkgtest.3.14.0.nupkg $ rm -rf bin obj $ dotnet pack -p:PackageVersion=2.718+metadata [...] $ ls **/*.nupkg bin/Release/nupkgtest.2.718.0.nupkg ``` This hopefully fixes a problem where arcade fails to find packages: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=10082514&view=logs&j=ba23343f-f710-5af9-782d-5bd26b102304&t=74531eb2-9b39-5603-839e-94e3ba212b65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nupkg filenames don't contain the metadata from the package version, so compute filenames without the metadata.
This naming behavior can be tested like this:
This hopefully fixes a problem where arcade fails to find packages:
https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=10082514&view=logs&j=ba23343f-f710-5af9-782d-5bd26b102304&t=74531eb2-9b39-5603-839e-94e3ba212b65
To double check: