Fix file encoding to UTF-8 for all scaffolded files#3449
Draft
Fix file encoding to UTF-8 for all scaffolded files#3449
Conversation
Co-authored-by: haileymck <[email protected]>
Copilot
AI
changed the title
[WIP] Fix file encoding to ensure UTF-8 compatibility
Fix file encoding to UTF-8 for all scaffolded files
Dec 18, 2025
Member
|
@copilot add unit tests |
Co-authored-by: haileymck <[email protected]>
Contributor
Author
Added comprehensive unit tests in commit 1742e9d. The tests cover:
All tests verify: Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scaffolded files used system default encoding (e.g., Windows-1251), causing non-ASCII characters to render incorrectly.
Changes
All
File.WriteAllTextandFile.WriteAllLinescalls now explicitly specify UTF-8 encoding without BOM:Files modified (11):
Microsoft.DotNet.Scaffolding.TextTemplating/TextTemplatingStep.csMicrosoft.DotNet.Scaffolding.Internal/Services/FileSystem.csMicrosoft.DotNet.Scaffolding.CodeModification/Helpers/ProjectModifierHelper.csMicrosoft.DotNet.Scaffolding.Shared/CodeModifier/DocumentBuilder.csMicrosoft.DotNet.Scaffolding.Shared/DefaultFileSystem.csMicrosoft.DotNet.Scaffolding.Shared/DotNetDispatcher/DotnetToolDispatcher.csMicrosoft.DotNet.MSIdentity/Tool/AppProvisioningTool.csMicrosoft.DotNet.MSIdentity/CodeReaderWriter/CodeWriter.csMicrosoft.DotNet.MSIdentity/CodeReaderWriter/ProjectModifier.csMicrosoft.DotNet.MSIdentity/MicrosoftIdentityPlatform/AppSettingsModifier.csVS.Web.CG.Mvc/Dependency/ReadMeGenerator.csPattern follows existing usage in
ProjectModifierHelper.cs:579and test fixtures.Unit Tests Added
Comprehensive unit tests were added to validate the encoding fixes:
DefaultFileSystemUTF-8 encodingInternal.Services.FileSystemWriteAllText and WriteAllLinesAll tests verify:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.