feat: Add telemetry hooks for SDK method execution duration#654
Open
ekumamatthew wants to merge 3 commits intodotandev:mainfrom
Open
feat: Add telemetry hooks for SDK method execution duration#654ekumamatthew wants to merge 3 commits intodotandev:mainfrom
ekumamatthew wants to merge 3 commits intodotandev:mainfrom
Conversation
Closes dotandev#622 - Implement optional MethodTelemetry interface for duration tracking - Add WithMethodTiming() for automatic span creation and timing - Add RecordMethodDuration() for manual duration recording - Instrument core network RPC methods (getTransaction, getLedgerHeader, getLedgerEntries, simulateTransaction) - Instrument simulator Run() method with timing and attributes - Add telemetry configuration options (telemetry_enabled, telemetry_exporter_url, telemetry_service_name) - Support both environment variables and TOML configuration - Add comprehensive test suite for telemetry functionality - Maintain backward compatibility with no-op implementation when disabled Performance metrics collected: - Method execution duration in seconds (histogram) - Method names, network info, RPC URLs as attributes - Transaction hashes, ledger sequences, simulator config This enables identification of performance bottlenecks in critical SDK methods.
Owner
|
fix conflicts, please. |
- Fix config.go: Add RequestTimeout field and remove telemetry conflicts - Fix simulator/runner.go: Keep both telemetry and validation functionality - Restore memory limit simulation functionality in main.rs - Update SimHost::new calls to include memory_limit parameter - Add memory limit checking after operation execution
- Keep both telemetry instrumentation and URL routing logic - Preserve circuit breaker functionality for Soroban endpoints - Maintain proper URL selection for getLedgerEntries and simulateTransaction methods
Owner
|
fix the newest conflicts, please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #622
Performance metrics collected: