Feat/rpc issue 67

[promisszn]

Closes #383

[Copilot]

Pull request overview

This pull request implements WebSocket-based transaction status streaming for Soroban RPC (closes #383), adds a --print flag to the trace command for non-interactive output, and includes several bug fixes and code cleanup tasks.

Changes:

• Adds WebSocket streaming support for transaction status updates with automatic fallback to HTTP polling
• Introduces --print and --no-color flags to the trace command for generating ASCII tree reports suitable for CI/logs
• Improves color handling in the visualizer with environment variable checks (NO_COLOR, FORCE_COLOR, TERM=dumb)
• Fixes XDR unmarshaling to use io.Reader interface
• Removes duplicate struct fields and unused code
• Adds dependencies for color output (fatih/color, mattn/go-colorable)

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
internal/rpc/txstream.go	New WebSocket streaming implementation with fallback to HTTP polling
internal/rpc/txstream_test.go	Comprehensive test coverage for streaming modes and edge cases
internal/trace/printer.go	New printer implementation for generating rich ASCII trace trees
internal/trace/printer_test.go	Tests for printer with color and width handling
internal/cmd/trace.go	Adds --print and --no-color CLI flags
internal/visualizer/color.go	Improved ColorEnabled() with env var checks, new Colorize() implementation
internal/visualizer/ansi.go	ANSI SGR constants moved from terminal package
internal/rpc/verification.go	Fixed XDR unmarshaling to use bytes.NewReader
internal/rpc/verification_test.go	Fixed XDR pointer usage for ContractId and ScSymbol
internal/trace/navigation.go	Removed duplicate struct fields
internal/dwarf/parser.go	Cleaned up WASM parsing code, removed unused unit field
internal/trace/treeui.go	Removed unused scrollbar calculation variable
internal/trace/search_unicode_test.go	Removed duplicate EventData line
internal/trace/node_test.go	Added missing closing brace for test function
internal/trace/node.go	Added fmt import for similarityKey()
internal/rpc/client_retry_test.go	Fixed test to use inline struct instead of undefined LedgerEntryResult
internal/rpc/client_test.go	Added missing closing brace
go.mod, go.sum	Added fatih/color, mattn/go-colorable, atotto/clipboard dependencies

Comments suppressed due to low confidence (1)

internal/dwarf/parser.go:193

• The function parseWASMSections and helper readULEB128 are defined but never actually called (parseWASM just returns ErrNoDebugInfo and uses a blank assignment to suppress the unused warning). Consider either removing this dead code entirely, or if it's intended for future use, add a TODO comment explaining the planned implementation. The current approach of keeping unused code with a suppression comment is not ideal for maintainability.

	_ = parseWASMSections // suppress unused warning
	return nil, ErrNoDebugInfo
}

// parseWASMSections parses custom sections from a WASM binary
func parseWASMSections(data []byte) map[string][]byte {
	sections := make(map[string][]byte)

	i := 8 // Skip WASM magic + version
	for i < len(data) {
		sectionID := data[i]
		i++

		// Read section size (LEB128 unsigned)
		sectionSize, n := readULEB128(data[i:])
		if n == 0 {
			break
		}
		i += n

		sectionEnd := i + int(sectionSize)
		if sectionEnd > len(data) {
			break
		}

		if sectionID == 0 { // Custom section
			// Read name length (LEB128 unsigned)
			nameLen, nn := readULEB128(data[i:])
			if nn == 0 {
				i = sectionEnd
				continue
			}
			nameStart := i + nn
			nameEnd := nameStart + int(nameLen)
			if nameEnd > sectionEnd {
				i = sectionEnd
				continue
			}

			name := string(data[nameStart:nameEnd])
			sections[name] = data[nameEnd:sectionEnd]
		}

		i = sectionEnd
	}

	return sections
}

// readULEB128 decodes an unsigned LEB128 value from buf.
// Returns the value and the number of bytes consumed; 0 bytes means the buffer
// was too short.
func readULEB128(buf []byte) (uint64, int) {
	var val uint64
	var shift uint
	for i, b := range buf {
		val |= uint64(b&0x7f) << shift
		if b&0x80 == 0 {
			return val, i + 1
		}
		shift += 7
		if shift >= 64 {
			return 0, 0
		}
	}
	return 0, 0
}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[dotandev]

check ci, they're all failing

[promisszn]

check now

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
27626607	Triggered	Generic Private Key	5dcaab8	integration/integration_test.go	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[dotandev]

check ci, they're still failing

[dotandev]

check ci, they're still failing