Ux/cli trace view by promisszn · Pull Request #629 · dotandev/hintents

promisszn · 2026-02-25T15:55:10Z

Closes #81

- Add internal/trace/printer.go: PrintExecutionTrace and PrintTraceTree with tree-style ASCII connectors, color-coded icons per event type, CPU/MEM budget lines, and a summary footer (Steps / Errors / Status) - Add --print and --no-color flags to 'erst trace' CLI command - Use github.com/fatih/color v1.18.0 for ANSI styling with NoColor support - Add printer_test.go: TestPrintTraceTree_NoColor, TestPrintExecutionTrace_NoColor, TestPrintOptions_Width - Add internal/visualizer/ansi.go: SGR constants for visualizer package - Fix pre-existing compilation/test errors: visualizer/color.go: bad merge + NO_COLOR/TERM=dumb env var support dwarf/parser.go: invalid stdlib DWARF API calls dwarf/parser_test.go: dwOpStackValue constant, duplicate struct fields trace/navigation.go: duplicate struct fields from bad merge trace/node.go: missing fmt import, unused variable trace/treeui.go: unused scrollPos variable trace/trap.go + trap_test.go: wrong SourceLocation type trace/viewer.go: redundant newline, add expand keyword to help trace/node_test.go + search_unicode_test.go: test compilation fixes

Copilot

Pull request overview

This PR implements a rich terminal trace visualization feature for the CLI, addressing Issue #81. It adds the ability to render execution traces as color-coded ASCII trees with support for both interactive viewing and one-shot printing suitable for CI/CD pipelines.

Changes:

Added trace printer with tree-style ASCII output and color coding using fatih/color library
Implemented --print and --no-color flags for non-interactive trace viewing
Refactored color handling in visualizer package to support dynamic NO_COLOR/FORCE_COLOR environment variables
Cleaned up duplicate struct fields, unused variables, and improved DWARF parser comments

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
internal/trace/printer.go	New file: Core trace printing implementation with tree rendering, color palette, and formatting utilities
internal/trace/printer_test.go	New file: Tests for printer functionality covering no-color mode and narrow terminal scenarios
internal/visualizer/color.go	Enhanced ColorEnabled() to check NO_COLOR/FORCE_COLOR/TERM env vars; refactored Colorize, Symbol, and indicator functions
internal/visualizer/ansi.go	New file: ANSI SGR escape code constants for visualizer package
internal/cmd/trace.go	Added --print and --no-color flags with integration to PrintExecutionTrace
internal/trace/viewer.go	Added help text for new "expand" command
internal/trace/treeui.go	Removed unused variable in scrollbar calculation
internal/trace/search_unicode_test.go	Fixed duplicate EventData field in test case
internal/trace/node_test.go	Added missing closing brace for test function
internal/trace/node.go	Added fmt import and removed unused variable
internal/trace/navigation.go	Deduplicated ExecutionState struct fields
internal/dwarf/parser_test.go	Clarified comment about Rust name demangling behavior
internal/dwarf/parser.go	Cleaned up parseWASM to stub out WASM support, improved comments, removed unused fields/functions
go.mod, go.sum	Added fatih/color and supporting dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/trace/printer.go

internal/dwarf/parser.go

internal/visualizer/ansi.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

- Add TxStreamer interface with Stream(ctx, hash) channel API - Implement wsStreamer: persistent WebSocket connection with periodic getTransaction JSON-RPC calls at 2s intervals - Implement pollingStreamer: HTTPS JSON-RPC polling at 3s intervals - NewTxStreamer factory probes for WebSocket support (3s timeout) and selects wsStreamer or pollingStreamer transparently - WebSocket protocol implemented per RFC 6455 using stdlib only: wsDialUpgrade, wsWriteFrame (masked), wsReadFrame, wsGenKey, wsAcceptKey -- no new external dependencies - Add telemetry spans: rpc_tx_stream_ws and rpc_tx_stream_poll - TxStatus constants: PENDING, SUCCESS, FAILED, NOT_FOUND - Add txstream_test.go with 15 tests covering unit + integration - Fix pre-existing compilation errors in verification.go, verification_test.go, client_test.go, client_retry_test.go

- Standardized formatting in `internal/trace/trap.go`, `internal/trace/trap_test.go`, and `internal/trace/treeui.go` for improved readability. - Updated `internal/updater/checker.go` to enhance update checking logic and error handling. - Modified `internal/visualizer/color.go` to adjust symbol representation. - Cleaned up imports in `internal/watch/spinner.go` and ensured consistent code style. - Added missing newline at the end of `main.go` for better file formatting. - Updated licensing headers in various scripts and test files to reflect authorship and licensing information. - Improved code structure and readability in `simulator/src/main.rs` and `simulator/src/runner.rs`. - Enhanced error handling and logging in `simulator/src/stack_trace.rs`. - Added licensing headers to TypeScript files in the audit and command directories. - Ensured consistent formatting and licensing in test files across the project.

…er, color, and main files

…ve unused imports

…t methods

dotandev · 2026-02-26T10:52:36Z

fix the newest conflicts, please.

…est files

gitguardian · 2026-02-26T11:20:20Z

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

^{_{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}}

promisszn · 2026-02-26T11:32:49Z

fixed

dotandev · 2026-02-27T08:57:52Z

check ci, they're failing

promisszn added 2 commits February 25, 2026 16:45

merge: resolve conflicts with main branch

7eadec1

Copilot AI review requested due to automatic review settings February 25, 2026 15:55

Copilot AI reviewed Feb 25, 2026

View reviewed changes

internal/trace/printer.go Outdated Show resolved Hide resolved

internal/trace/printer.go Outdated Show resolved Hide resolved

internal/dwarf/parser.go Outdated Show resolved Hide resolved

internal/visualizer/ansi.go Show resolved Hide resolved

promisszn and others added 15 commits February 25, 2026 17:10

Update internal/visualizer/ansi.go

636fbe0

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update internal/trace/printer.go

c46ece9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update internal/trace/printer.go

06bd843

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into ux/cli-trace-view

ca45b35

Merge branch 'main' into feat/rpc-issue-67

8850446

Remove unnecessary blank line in Symbol function

ca8eb0b

Refactor WASM-related constants and clean up code in discovery, check…

994056b

…er, color, and main files

Merge branch 'main' into feat/rpc-issue-67

8066c49

Merge branch 'main' into ux/cli-trace-view

134966b

Merge branch 'feat/rpc-issue-67' into ux/cli-trace-view

05b6347

Refactor ANSI color constants to use direct escape sequences and remo…

6e82ce5

…ve unused imports

Merge branch 'main' into ux/cli-trace-view

46bf377

Refactor variable declarations and improve error logging in RPC clien…

4dcb2be

…t methods

promisszn added 2 commits February 26, 2026 12:16

Merge branch 'main' into ux/cli-trace-view

925a8e3

refactor: clean up unused variables and remove trailing newlines in t…

308d1bc

…est files

refactor: update context return types in test helper functions

1d908f4

promisszn force-pushed the ux/cli-trace-view branch from 242340e to 1d908f4 Compare February 26, 2026 11:31

Merge branch 'main' into ux/cli-trace-view

1500797

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ux/cli trace view#629

Ux/cli trace view#629
promisszn wants to merge 21 commits intodotandev:mainfrom
promisszn:ux/cli-trace-view

promisszn commented Feb 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dotandev commented Feb 26, 2026

Uh oh!

gitguardian bot commented Feb 26, 2026 •

edited

Loading

Uh oh!

promisszn commented Feb 26, 2026

Uh oh!

dotandev commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

promisszn commented Feb 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dotandev commented Feb 26, 2026

Uh oh!

gitguardian bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

️✅ There are no secrets present in this pull request anymore.

Uh oh!

promisszn commented Feb 26, 2026

Uh oh!

dotandev commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gitguardian bot commented Feb 26, 2026 •

edited

Loading