Review: audit fixes and sort logic improvements

.env.example

@@ -33,6 +33,7 @@ SESSION_LIFETIME=120
 SESSION_ENCRYPT=false
 SESSION_PATH=/
 SESSION_DOMAIN=null
+SESSION_COOKIE=teal_session
 
 BROADCAST_CONNECTION=log
 FILESYSTEM_DISK=local

.githooks/pre-push

@@ -0,0 +1,12 @@
+#!/usr/bin/env bash
+# Fast local gate before pushing: style + static analysis.
+# Tests run in CI (they need a database); keep this loop quick.
+set -euo pipefail
+
+echo "[pre-push] Pint (style)…"
+./vendor/bin/pint --test
+
+echo "[pre-push] PHPStan (max, baseline-gated)…"
+php -d memory_limit=2G vendor/bin/phpstan analyse --no-progress
+
+echo "[pre-push] ok — pushing."

.github/workflows/tests.yml

@@ -1,13 +1,54 @@
-name: Tests
+name: CI
 
 on:
   push:
     branches: [ "main" ]
   pull_request:
-    branches: [ "main" ]
 
 jobs:
-  laravel-tests:
+  quality:
+    name: Quality (Pint + PHPStan)
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: shivammathur/setup-php@v2
+        with:
+          php-version: '8.4'
+          extensions: mbstring, xml, ctype, iconv, intl, pdo_pgsql
+          coverage: none
+          tools: composer:v2
+      - name: Copy .env
+        run: php -r "file_exists('.env') || copy('.env.example', '.env');"
+      - name: Install dependencies
+        run: composer install -q --no-ansi --no-interaction --no-progress --prefer-dist
+      - name: Generate key
+        run: php artisan key:generate
+      - name: Pint (style check)
+        run: vendor/bin/pint --test
+      - name: PHPStan (max, baseline-gated)
+        run: vendor/bin/phpstan analyse --no-progress --memory-limit=2G
+
+  rector:
+    name: Rector (advisory)
+    runs-on: ubuntu-latest
+    continue-on-error: true
+    steps:
+      - uses: actions/checkout@v4
+      - uses: shivammathur/setup-php@v2
+        with:
+          php-version: '8.4'
+          extensions: mbstring, xml, ctype, iconv, intl, pdo_pgsql
+          coverage: none
+          tools: composer:v2
+      - name: Copy .env
+        run: php -r "file_exists('.env') || copy('.env.example', '.env');"
+      - name: Install dependencies
+        run: composer install -q --no-ansi --no-interaction --no-progress --prefer-dist
+      - name: Rector (dry-run, advisory)
+        run: vendor/bin/rector process --dry-run --no-progress-bar
+
+  tests:
+    name: Tests (Pest)
     runs-on: ubuntu-latest
 
     services:

README.md

@@ -62,6 +62,32 @@ COMIC_VINE_API_KEY=your_key
 
 Book metadata (OpenLibrary) and anime metadata (Jikan/MAL) work without API keys.
 
+## Development
+
+### Coding standard
+
+The codebase follows **PSR-12** (and, by extension, PSR-1 for basic style and PSR-4 for autoloading). Style is enforced with [Laravel Pint](https://laravel.com/docs/pint) using the `laravel` preset — a PSR-12 superset that adds Laravel idioms — configured in `pint.json`. Every PHP file declares `strict_types=1`.
+
+```bash
+composer lint      # check formatting (pint --test), no changes
+./vendor/bin/pint  # apply formatting
+```
+
+### Static analysis
+
+[PHPStan](https://phpstan.org/) via [Larastan](https://github.com/larastan/larastan) runs at `level: max`, configured in `phpstan.neon`. Existing findings are captured in `phpstan-baseline.neon`; new code must not add to the baseline. Declared-type coverage floors (return/param/property) ratchet up over time and cannot regress.
+
+```bash
+composer stan      # phpstan analyse
+composer quality   # lint + stan
+```
+
+A `pre-push` hook (`.githooks/pre-push`, enabled via `composer hooks`) runs Pint and PHPStan before every push. Tests run in CI.
+
+```bash
+composer test      # Pest suite (needs the teal_test database)
+```
+
 ## License
 
 MIT

app/Console/Commands/EnrichMovies.php

@@ -1,45 +1,57 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Console\Commands;
 
+use App\Enums\WatchingStatus;
 use App\Models\Movie;
 use App\Services\TmdbService;
 use App\Services\TraktService;
 use Illuminate\Console\Command;
+use Illuminate\Support\Sleep;
 
 class EnrichMovies extends Command
 {
     protected $signature = 'app:enrich-movies {--limit=50}';
+
     protected $description = 'Enrich movies and TV shows with metadata from TMDB and Trakt';
 
-    public function handle(TmdbService $tmdb, TraktService $trakt)
+    public function handle(TmdbService $tmdb, TraktService $trakt): int
     {
         $limit = (int) $this->option('limit');
-        
+
         $movies = Movie::whereNotNull('imdb_id')
-            ->where('status', \App\Enums\WatchingStatus::Watchlist->value)
-            ->where(function($q) {
+            ->where('status', WatchingStatus::Watchlist->value)
+            ->where(function ($q): void {
                 $q->whereNull('poster_url')
-                  ->orWhereNull('description');
+                    ->orWhereNull('description');
             })
             ->take($limit)
             ->get();
 
         if ($movies->isEmpty()) {
-            $this->info("No movies need enrichment.");
-            return;
+            $this->info('No movies need enrichment.');
+
+            return self::SUCCESS;
         }
 
         $this->info("Enriching {$movies->count()} items...");
 
         foreach ($movies as $movie) {
-            $this->line("Processing: {$movie->title} ({$movie->imdb_id})");
-
-            $data = $tmdb->findByImdbId($movie->imdb_id);
-
-            if (!$data) {
-                $this->warn("  TMDB miss, trying Trakt...");
-                $data = $trakt->findByImdbId($movie->imdb_id);
+            $imdbId = $movie->imdb_id;
+
+            if (! is_string($imdbId)) {
+                continue;
+            }
+
+            $this->line("Processing: {$movie->title} ({$imdbId})");
+
+            $data = $tmdb->findByImdbId($imdbId);
+
+            if (! $data) {
+                $this->warn('  TMDB miss, trying Trakt...');
+                $data = $trakt->findByImdbId($imdbId);
             }
 
             if ($data) {
@@ -53,30 +65,30 @@ public function handle(TmdbService $tmdb, TraktService $trakt)
                     'metadata_fetched_at' => now(),
                 ]);
 
-                if (!empty($updates)) {
-                    $movie->update($updates);
-                    $this->info("  Updated metadata.");
-
-                    // If this is a show name, propagate the poster to episodes
-                    if (($movie->title_type === 'TV Series' || $movie->title_type === 'TV Mini Series') && $movie->poster_url) {
-                        Movie::propagateShowPoster(
-                            $movie->user_id, 
-                            $movie->title, 
-                            $movie->title, 
-                            $movie->poster_url, 
-                            $movie->title
-                        );
-                    }
+                $movie->update($updates);
+                $this->info('  Updated metadata.');
+
+                // If this is a show name, propagate the poster to episodes
+                if (($movie->title_type === 'TV Series' || $movie->title_type === 'TV Mini Series') && $movie->poster_url) {
+                    Movie::propagateShowPoster(
+                        $movie->user_id,
+                        $movie->title,
+                        $movie->title,
+                        $movie->poster_url,
+                        $movie->title
+                    );
                 }
             } else {
-                $this->error("  No metadata found for {$movie->imdb_id}");
+                $this->error("  No metadata found for {$imdbId}");
                 $movie->update(['metadata_fetched_at' => now()]);
             }
 
             // Simple rate limit protection (4 requests per second)
-            usleep(250000); 
+            Sleep::usleep(250000);
         }
 
-        $this->info("Enrichment complete.");
+        $this->info('Enrichment complete.');
+
+        return self::SUCCESS;
     }
 }

app/Console/Commands/FixBookStatuses.php

@@ -15,6 +15,7 @@ class FixBookStatuses extends Command
 
     protected $description = 'Fix book statuses and optionally extract shelves from the shelves field';
 
+    /** @var list<string> */
     private array $statusKeywords = ['read', 'to-read', 'currently-reading', 'want-to-read', 'reading'];
 
     public function handle(): int
@@ -27,11 +28,11 @@ public function handle(): int
         $total = Book::whereNotNull('shelves')->count();
         $this->info("Processing {$total} books with shelf data...");
 
-        Book::whereNotNull('shelves')->with('user')->each(function (Book $book) use ($extractShelves, &$statusUpdated, &$shelvesCreated, &$booksWithShelves) {
-            $shelfParts = array_map('trim', explode(',', $book->shelves ?? ''));
+        Book::whereNotNull('shelves')->with('user')->each(function (Book $book) use ($extractShelves, &$statusUpdated, &$shelvesCreated, &$booksWithShelves): void {
+            $shelfParts = array_map(trim(...), explode(',', $book->shelves ?? ''));
 
             // First part is always status
-            $statusPart = strtolower($shelfParts[0] ?? '');
+            $statusPart = strtolower($shelfParts[0]);
 
             // Determine correct status
             if (str_contains($statusPart, 'to-read') || str_contains($statusPart, 'want')) {
@@ -52,13 +53,16 @@ public function handle(): int
             // Extract custom shelves (everything after the first part that isn't a status keyword)
             if ($extractShelves && count($shelfParts) > 1) {
                 $customShelves = [];
+                $counter = count($shelfParts);
 
-                for ($i = 1; $i < count($shelfParts); $i++) {
+                for ($i = 1; $i < $counter; $i++) {
                     $shelfName = trim($shelfParts[$i]);
                     $shelfLower = strtolower($shelfName);
-
                     // Skip if it's a status keyword
-                    if (empty($shelfName) || in_array($shelfLower, $this->statusKeywords)) {
+                    if (empty($shelfName)) {
+                        continue;
+                    }
+                    if (in_array($shelfLower, $this->statusKeywords)) {
                         continue;
                     }
 
@@ -67,7 +71,7 @@ public function handle(): int
                     $shelvesCreated++;
                 }
 
-                if (! empty($customShelves)) {
+                if ($customShelves !== []) {
                     $book->bookShelves()->syncWithoutDetaching($customShelves);
                     $booksWithShelves++;
                 }

app/Console/Commands/ImportGoodreads.php

@@ -4,8 +4,9 @@
 
 namespace App\Console\Commands;
 
-use App\Services\JsonImportService;
 use App\Models\User;
+use App\Services\JsonImportService;
+use Exception;
 use Illuminate\Console\Command;
 
 class ImportGoodreads extends Command
@@ -19,23 +20,31 @@ public function handle(): int
         $userId = (int) $this->argument('user_id');
         $user = User::find($userId);
 
-        if (!$user) {
+        if (! $user) {
             $this->error("User with ID {$userId} not found");
+
             return 1;
         }
 
         $filePath = base_path('goodreads.txt');
 
-        if (!file_exists($filePath)) {
+        if (! file_exists($filePath)) {
             $this->error("File not found: {$filePath}");
+
             return 1;
         }
 
         $this->info('Reading goodreads.txt...');
         $content = file_get_contents($filePath);
 
+        if ($content === false) {
+            $this->error("Could not read: {$filePath}");
+
+            return 1;
+        }
+
         try {
-            $service = new JsonImportService();
+            $service = new JsonImportService;
             $books = $service->parseJson($content);
 
             $this->info("Parsed {$books->count()} books");
@@ -68,8 +77,9 @@ public function handle(): int
             $this->info("✓ No changes needed: {$skipped} books");
 
             return 0;
-        } catch (\Exception $e) {
-            $this->error('Import failed: ' . $e->getMessage());
+        } catch (Exception $e) {
+            $this->error('Import failed: '.$e->getMessage());
+
             return 1;
         }
     }