-
-
Notifications
You must be signed in to change notification settings - Fork 70
[no-release-notes] update mini sysbench to use kubernetes #3056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,20 +34,37 @@ jobs: | |
| github-token: ${{ secrets.REPO_ACCESS_TOKEN || secrets.GITHUB_TOKEN }} | ||
| script: | | ||
| const { ACTOR, FORMAT, ISSUE_NUMBER, GITHUB_WORKSPACE } = process.env; | ||
| const issue_number = parseInt(ISSUE_NUMBER, 10); | ||
| const { owner, repo } = context.repo; | ||
| fs = require('fs'); | ||
| fs.readFile(`${GITHUB_WORKSPACE}/results.log`, 'utf8', function (err,data) { | ||
| if (err) { | ||
| return console.log(err); | ||
| } | ||
| return github.rest.issues.createComment({ | ||
| issue_number, | ||
| owner, | ||
| repo, | ||
| body: `@${ACTOR} ${FORMAT}\n ${data}` | ||
| }); | ||
| const issue_number = parseInt(ISSUE_NUMBER, 10); | ||
|
|
||
| const fs = require('fs').promises; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🆕 New Failure: identified in this diff run
|
||
| const resData = await fs.readFile(`${GITHUB_WORKSPACE}/results.log`, 'utf8'); | ||
|
|
||
| const commentMarker = '<!-- go-run-output-sysbench -->'; | ||
|
|
||
| // List comments on the PR | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🆕 New Failure: identified in this diff run
|
||
| const { data: comments } = await github.rest.issues.listComments({ | ||
| issue_number: issue_number, | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo | ||
| }); | ||
|
|
||
| // Check if a comment already exists | ||
| const comment = comments.find(comment => comment.body.includes(commentMarker)) | ||
| comment_id: comment.id, | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| body: `${commentMarker}\n@${ACTOR} ${FORMAT}\n${resData}` | ||
| }) | ||
| } else { | ||
| // Create a new comment | ||
| await github.rest.issues.createComment({ | ||
| issue_number: issue_number, | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| body: `${commentMarker}\n@${ACTOR} ${FORMAT}\n${resData}` | ||
| }); | ||
| } | ||
| env: | ||
| ACTOR: ${{ github.event.client_payload.actor }} | ||
| ISSUE_NUMBER: ${{ github.event.client_payload.issue_number }} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| name: Mini Sysbench | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened] | ||
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
|
|
||
| jobs: | ||
| mini-sysbench: | ||
| name: Trigger Mini Benchmark Latency K8s Workflow | ||
| if: github.actor != 'dependabot[bot]' | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - name: Build benchmark payload (main HEAD + PR HEAD) | ||
| uses: actions/github-script@v7 | ||
| id: build_payload | ||
| with: | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| script: | | ||
| // For PR benchmarks, use the PR base commit (the exact target commit this PR was opened/updated against), | ||
| // not the moving HEAD of `main`. | ||
| const fromSha = context.payload.pull_request.base.sha; | ||
|
|
||
| // The latest commit on the PR branch. | ||
| const toSha = context.payload.pull_request.head.sha; | ||
|
|
||
| const payload = { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🆕 New Failure: identified in this diff run
|
||
| from_server: "doltgres", | ||
| from_version: fromSha, | ||
| to_server: "doltgres", | ||
| to_version: toSha, | ||
| mode: "pullRequest", | ||
| issue_number: String(context.issue.number), | ||
| init_big_repo: "true", | ||
| actor: context.actor, | ||
| sysbench_test_time: "20", | ||
| template_script: "./.github/scripts/performance-benchmarking/get-doltgres-doltgres-job-json.sh", | ||
| }; | ||
|
|
||
| core.setOutput("from_sha", fromSha); | ||
| core.setOutput("to_sha", toSha); | ||
| core.setOutput("payload", JSON.stringify(payload)); | ||
| - name: Log benchmark versions | ||
| shell: bash | ||
| run: | | ||
| echo "from_version_sha=${{ steps.build_payload.outputs.from_sha }}" | ||
| echo "to_version_sha=${{ steps.build_payload.outputs.to_sha }}" | ||
| - uses: peter-evans/repository-dispatch@v3 | ||
| with: | ||
| token: ${{ secrets.REPO_ACCESS_TOKEN }} | ||
| event-type: benchmark-latency | ||
| client-payload: ${{ steps.build_payload.outputs.payload }} | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆕 New Failure: identified in this diff run
What failed: Starting a nightly benchmark with TPCC enabled produces a job with --sysbench-test-time=true and no --withTpcc=true option. The launcher accepts and applies the job instead of rejecting the incompatible caller contract.
Impact · Steps · Stub / mock · Analysis · Why this is likely a bug
Relevant code
.github/scripts/performance-benchmarking/run-benchmarks.sh:72-85.github/scripts/performance-benchmarking/get-doltgres-doltgres-job-json.sh:19-22.github/scripts/performance-benchmarking/get-doltgres-doltgres-job-json.sh:33-39.github/scripts/performance-benchmarking/get-doltgres-doltgres-job-json.sh:101-107Evidence Package
Copy prompt for an agent