Postgres implementation, make tests work with postgres - #48
Merged
Conversation
coffeegoddd
approved these changes
Apr 20, 2026
coffeegoddd
left a comment
coffeegoddd
left a comment
Contributor
There was a problem hiding this comment.
Generally looks really good, just a couple questions/comments. I think it's missing changes to the README.md that give the end user information about how to use this new mode/configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
Dialectinterface for Postgres (dialect_postgres.go). It also makes the test runner logic dialect-aware and adds appropriate setup/teardown SQL to make the tests work for Postgres.