Skip to content

more mndiagram#2141

Draft
itsgrimetime wants to merge 1 commit intodoldecomp:masterfrom
itsgrimetime:pr/mndiagram-module
Draft

more mndiagram#2141
itsgrimetime wants to merge 1 commit intodoldecomp:masterfrom
itsgrimetime:pr/mndiagram-module

Conversation

@itsgrimetime
Copy link
Contributor

@itsgrimetime itsgrimetime commented Jan 27, 2026

still WIP

some more matches + documentation in mndiagram & mndiagram2. start matching mndiagram3 as well

@decomp-dev
Copy link

decomp-dev bot commented Jan 27, 2026

Report for GALE01 (f075222 - b179ba2)

📈 Matched code: 53.20% (+0.03%, +1144 bytes)

✅ 6 new matches
Unit Item Bytes Before After
main/melee/mn/mndiagram3 mnDiagram3_80247008 +324 0.00% 100.00%
main/melee/mn/mndiagram3 mnDiagram3_80246F2C +220 0.00% 100.00%
main/melee/mn/mndiagram3 fn_80246E64 +168 0.00% 100.00%
main/melee/mn/mndiagram3 fn_80246E04 +96 0.00% 100.00%
main/melee/mn/mndiagram mnDiagram_PopupInputProc +53 68.00% 100.00%
main/melee/mn/mndiagram2 mnDiagram2_PopulateStatRows +8 95.35% 100.00%
📈 18 improvements in unmatched items
Unit Item Bytes Before After
main/melee/mn/mndiagram3 mnDiagram3_80245BA4 +1426 0.00% 91.47%
main/melee/mn/mndiagram3 mnDiagram3_8024714C +801 0.00% 90.20%
main/melee/mn/mndiagram3 mnDiagram3_80246D40 +193 0.00% 98.57%
main/melee/mn/mndiagram2 mnDiagram2_Create +106 75.00% 93.77%
main/melee/mn/mndiagram2 mnDiagram2_GetRankedName +88 81.51% 97.87%
main/melee/mn/mndiagram2 mnDiagram2_CreateStatRow +78 82.12% 87.31%
main/melee/mn/mndiagram mnDiagram_PopupAnimProc +70 60.61% 74.29%
main/melee/mn/mndiagram mnDiagram_80243434 +45 67.25% 72.03%
main/melee/mn/mndiagram mnDiagram_OnFrame +36 90.66% 96.31%
main/melee/mn/mndiagram mnDiagram_80241E78 +35 91.71% 95.14%
main/melee/mn/mndiagram2 mnDiagram2_GetRankedFighter +29 75.23% 79.94%
main/melee/mn/mndiagram mnDiagram_InputProc +27 21.85% 22.71%
main/melee/mn/mndiagram2 mnDiagram2_UpdateHeader +25 87.78% 94.18%
main/melee/mn/mndiagram2 mnDiagram2_HandleInput +14 88.42% 89.34%
main/melee/mn/mndiagram2 mnDiagram2_UpdateScrollArrows +14 95.55% 98.40%
main/melee/mn/mndiagram3 .sdata +14 0.00% 89.66%
main/melee/mn/mndiagram3 .sdata2 +13 0.00% 33.33%
main/melee/mn/mndiagram mnDiagram_80241310 0 99.11% 99.11%
📉 2 regressions in unmatched items
Unit Item Bytes Before After
main/melee/mn/mndiagram mnDiagram_80242C0C -56 65.20% 59.97%
main/melee/mn/mndiagram2 .sdata2 -7 50.00% 33.33%

mndiagram.c:
- Improve mnDiagram_80241310 (CreatePopup): 99.1%
- Improve mnDiagram_802417D0 (UpdateScrollArrows): 97.3%
- Improve mnDiagram_OnFrame: 96.3%
- Match mnDiagram_GetLeastPlayedFighter: 96.9%
- Match mnDiagram_PopupInputProc: bytes match
- Improve mnDiagram_8023FA6C (SortFightersByKOs): 80.8%
- Improve mnDiagram_PopupAnimProc: 60.6%
- Improve mnDiagram_80241E78 (DrawCellNumber): 91.7%
- Add HSD_JObjSetTranslateX/Y inlines with assert fix
- Fix extern types for SDA relocation correctness

mndiagram2.c:
- Match mnDiagram2_Init: 100%
- Match mnDiagram2_Think: 100%
- Improve mnDiagram2_UpdateHeader: 92.2%
- Improve mnDiagram2_HandleInput: 88.4%
- Improve mnDiagram2_GetStatValue: 95.0%
- Improve mnDiagram2_CreateStatRow: 83.1%
- Improve mnDiagram2_UpdateScrollArrows: 98.4%
- Improve mnDiagram2_ClearDetailView: 98.2%
- Improve mnDiagram2_Create: 76.5%
- Improve mnDiagram2_GetRankedFighter: 75.2%
- Improve mnDiagram2_GetRankedName: 81.5%
- Improve mnDiagram2_GetAggregatedFighterRank: 81.9%
- Fix InitUserData prototype (add unused int param)

mndiagram3.c:
- Match fn_80246E04: 100%
- Match mnDiagram3_80246F2C: 100%
- Match fn_80246E64: bytes match
- Match mnDiagram3_80247008: bytes match
- First-pass mnDiagram3_80245BA4: 56.6%
- First-pass mnDiagram3_8024714C: 66.2%
- First-pass mnDiagram3_80246D40: 79%
- Add Diagram3 struct (0x78 bytes) to types.h
- Add mndiagram3.static.h with extern declarations

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant