Skip to content

Comments

mp: Match mpLib_80053ECC_Floor and update mpisland.h signatures#2040

Closed
itsgrimetime wants to merge 4 commits intodoldecomp:masterfrom
itsgrimetime:subdirs/mp
Closed

mp: Match mpLib_80053ECC_Floor and update mpisland.h signatures#2040
itsgrimetime wants to merge 4 commits intodoldecomp:masterfrom
itsgrimetime:subdirs/mp

Conversation

@itsgrimetime
Copy link
Contributor

Summary

  • Match mpLib_80053ECC_Floor function using goto-based loop structure for correct codegen
  • Update mpisland.h function signatures from UNK_RET/UNK_PARAMS placeholders to proper types

Test plan

  • Build passes with ninja
  • mpLib_80053ECC_Floor matches at 100% on decomp.me

🤖 Generated with Claude Code

@decomp-dev
Copy link

decomp-dev bot commented Dec 30, 2025

Report for GALE01 (5f15eeb - bd1ac7c)

📈 1 improvement in unmatched functions
Unit Item Bytes Before After
main/melee/mp/mplib mpLib_80053ECC_Floor +16 89.53% 94.89%

@itsgrimetime
Copy link
Contributor Author

I think I gotta rework this one a bit, I think recently merged changes affected it's match %, will switch to draft for now

@itsgrimetime itsgrimetime marked this pull request as draft January 5, 2026 22:29
itsgrimetime and others added 2 commits January 5, 2026 23:10
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants