-
Notifications
You must be signed in to change notification settings - Fork 5
feat(processors): store update members #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bengineer42
wants to merge
15
commits into
dojoengine:main
Choose a base branch
from
bengineer42:add-update-members
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7601f59
feat(processors): add StoreUpdateMembersProcessor for handling member…
bengineer42 a6df3a6
feat(processors): enhance task identifier and indexing mode with memb…
bengineer42 07b3f1b
Merge branch 'main' into add-update-members
bengineer42 56aeb30
fix(dependencies): update dojo-world to version 1.5.1
bengineer42 6231518
fix(dependencies): update dojo dependencies to use the correct reposi…
bengineer42 d66ea1e
fix(dependencies): update dojo packages to version 1.5.1 and add bors…
bengineer42 bd8b865
feat(model): add use_legacy_storage method to ModelSQLReader
bengineer42 705c5c8
feat(tests): add update_player_config_items execution in test_load_fr…
bengineer42 6c95927
Merge branch 'main' into add-update-members
bengineer42 82c52c1
Updated lock file
bengineer42 7bb935e
feat(processor): refactor process method to use EventProcessorContext…
bengineer42 7cbb4b3
fix(dependencies): update dojo dependencies to point to the correct r…
bengineer42 135fdf9
fix(tests): update execute method version in test_load_from_remote_up…
bengineer42 cccbc06
Merge branch 'main' into add-update-members
bengineer42 3b05eb7
fix(tests): update calldata in test_load_from_remote_update for playe…
bengineer42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1089,6 +1089,34 @@ async fn test_load_from_remote_update(sequencer: &RunnerCtx) { | |
| .await | ||
| .unwrap(); | ||
|
|
||
| let res = account | ||
| .execute_v3(vec![Call { | ||
| to: actions_address, | ||
| selector: get_selector_from_name("update_player_config_items").unwrap(), | ||
| calldata: vec![Felt::ZERO], | ||
| }]) | ||
| .send_with_cfg(&TxnConfig::init_wait()) | ||
| .await | ||
| .unwrap(); | ||
|
|
||
| TransactionWaiter::new(res.transaction_hash, &provider) | ||
| .await | ||
| .unwrap(); | ||
|
|
||
| let res = account | ||
| .execute_v3(vec![Call { | ||
| to: actions_address, | ||
| selector: get_selector_from_name("update_player_config_items").unwrap(), | ||
| calldata: vec![Felt::from(1), Felt::from(1), Felt::from(20), Felt::from(12)], | ||
| }]) | ||
| .send_with_cfg(&TxnConfig::init_wait()) | ||
| .await | ||
| .unwrap(); | ||
|
|
||
| TransactionWaiter::new(res.transaction_hash, &provider) | ||
| .await | ||
| .unwrap(); | ||
|
|
||
| let world_reader = WorldContractReader::new(world_address, Arc::clone(&provider)); | ||
|
|
||
| let tempfile = NamedTempFile::new().unwrap(); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need to check that the state of the model from the DB is the correct one |
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might wanna make multiple updates and verify that the latest state is the latest one.