fix: Handle COUNT(*) as column name in KQL dialect#38
Closed
LiamTorrelli wants to merge 7 commits intomainfrom
Closed
fix: Handle COUNT(*) as column name in KQL dialect#38LiamTorrelli wants to merge 7 commits intomainfrom
LiamTorrelli wants to merge 7 commits intomainfrom
Conversation
Contributor
|
@LiamTorrelli, I was working on this seperately as well. I have a PR (#39). The changes on that are a little more minimal. Perhaps, would you want to check if it works for all cases you had ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where using COUNT() as a column name in Apache
Superset's drill-by functionality would result in a 'Semantic error:
Unsupported calculated column name COUNT()' error.
Changes:
The fix ensures that COUNT() is properly translated to count() when used as
a function and properly quoted as ["COUNT()"] when used as a column name or
alias, which resolves the error in Superset's drill-by functionality."