🛡️ Sentinel: [MEDIUM] Fix SQL syntax error / DoS vector on empty memory recall#164
Open
🛡️ Sentinel: [MEDIUM] Fix SQL syntax error / DoS vector on empty memory recall#164
Conversation
…ry recall * Update `src/codomyrmex/agentic_memory/cognilayer_bridge.py` * Add explicit check for empty search terms to avoid generating invalid SQLite WHERE clauses (e.g. `WHERE LIMIT ?`) * Run full verification suite to ensure test stability Co-authored-by: docxology <6911384+docxology@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
🤖 Hi @docxology, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
🤖 I'm sorry @docxology, but I was unable to process your request. Please see the logs for more details. |
…ry recall * Update `src/codomyrmex/agentic_memory/cognilayer_bridge.py` * Add explicit check for empty search terms to avoid generating invalid SQLite WHERE clauses (e.g. `WHERE LIMIT ?`) * Run full verification suite to ensure test stability Co-authored-by: docxology <6911384+docxology@users.noreply.github.com>
…memory recall * Update `src/codomyrmex/agentic_memory/cognilayer_bridge.py` * Add explicit check for empty search terms to avoid generating invalid SQLite WHERE clauses (e.g. `WHERE LIMIT ?`) * Run full verification suite to ensure test stability Co-authored-by: docxology <6911384+docxology@users.noreply.github.com>
…memory recall * Update `src/codomyrmex/agentic_memory/cognilayer_bridge.py` * Add explicit check for empty search terms to avoid generating invalid SQLite WHERE clauses (e.g. `WHERE LIMIT ?`) * Run full verification suite to ensure test stability Co-authored-by: docxology <6911384+docxology@users.noreply.github.com>
…memory recall * Update `src/codomyrmex/agentic_memory/cognilayer_bridge.py` * Add explicit check for empty search terms to avoid generating invalid SQLite WHERE clauses (e.g. `WHERE LIMIT ?`) * Run full verification suite to ensure test stability Co-authored-by: docxology <6911384+docxology@users.noreply.github.com>
…memory recall * Update `src/codomyrmex/agentic_memory/cognilayer_bridge.py` * Add explicit check for empty search terms to avoid generating invalid SQLite WHERE clauses (e.g. `WHERE LIMIT ?`) * Run full verification suite to ensure test stability Co-authored-by: docxology <6911384+docxology@users.noreply.github.com>
…memory recall * Update `src/codomyrmex/agentic_memory/cognilayer_bridge.py` * Add explicit check for empty search terms to avoid generating invalid SQLite WHERE clauses (e.g. `WHERE LIMIT ?`) * Run full verification suite to ensure test stability Co-authored-by: docxology <6911384+docxology@users.noreply.github.com>
…memory recall * Update `src/codomyrmex/agentic_memory/cognilayer_bridge.py` * Add explicit check for empty search terms to avoid generating invalid SQLite WHERE clauses (e.g. `WHERE LIMIT ?`) * Fix GitHub Actions permissions for commenting on PRs Co-authored-by: docxology <6911384+docxology@users.noreply.github.com>
📊 File Changes AnalysisChange AnalysisSource Code Changes
Configuration Changes
Analysis
|
🔒 Security Scan Results🔒 Comprehensive Security ReportGenerated on: Sat Mar 14 02:59:54 UTC 2026 SummaryDependency SecurityCurrent DependenciesVulnerability Scan ResultsNo vulnerabilities found or scan failed Safety Scan ResultsStatic Security Analysis (Bandit)Bandit Security Analysis ReportGenerated on: Sat Mar 14 02:59:39 UTC 2026 SummaryKey Metrics475 assert "Total Issues" in content License ComplianceLicense Compliance ReportGenerated on: Sat Mar 14 02:57:25 UTC 2026 Dependencies and Their LicensesLicense SummaryRecommendations
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 Severity: MEDIUM
💡 Vulnerability: Unhandled SQL syntax exception in
recall_memoryedge case🎯 Impact: If
queryis an empty string or whitespace,query.split()creates an empty list, andwhere_clausesresolves to"". The resulting querySELECT * FROM memories WHERE LIMIT ?throws a fatalsqlite3.OperationalError, potentially causing application crash/Denial of Service.🔧 Fix: Added an explicit
if not search_terms:condition to run a directSELECT * FROM memories LIMIT ?if no parameters are available.✅ Verification: Ran
uv run pytest src/codomyrmex/tests/unit/agentic_memory/ensuring 100% stable execution anduv run ruff checkfor static validation.PR created automatically by Jules for task 18291660171048009927 started by @docxology