Skip to content

Conversation

@crazy-max
Copy link
Member

This is just for extra safety. It should not matter as secrets passed to password attribute in registry-auth YAML object are already redacted.

@crazy-max crazy-max requested a review from tonistiigi January 6, 2026 14:01
@crazy-max crazy-max marked this pull request as ready for review January 6, 2026 14:02
@tonistiigi
Copy link
Member

@crazy-max Just a reminder that in some cases masking too many things as secret can leak the variable. Eg. if you see *** build -f ***file . then someone is using docker as a password.

@crazy-max
Copy link
Member Author

@crazy-max Just a reminder that in some cases masking too many things as secret can leak the variable. Eg. if you see *** build -f ***file . then someone is using docker as a password.

Yes true, that's why we switched from secrets to vars for username in our docs: https://github.com/docker/login-action?tab=readme-ov-file#usage

@crazy-max crazy-max merged commit 916386b into docker:master Jan 7, 2026
9 checks passed
@crazy-max crazy-max deleted the ensure-redact branch January 7, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants