[28.x backport] cli/connhelper: remove dependency on pkg/process #6262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
kind/refactor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This package will not be included in the api or client modules, and we're currently only using a single function of it, and only the unix implementation, so let's fork it for now (although the package may be moved to moby/sys). This removes the last dependency on github.com/docker/docker. Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 2abcbf8) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
28.x_backport_no_pkg_process
branch
from
c9e9edf to
7399781
Compare
vvoland
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package will not be included in the api or client modules, and we're currently only using a single function of it, and only the unix implementation, so let's fork it for now (although the package may be moved to moby/sys).
This removes the last dependency on github.com/docker/docker.
(cherry picked from commit 2abcbf8)
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)