Rename update.sh/target-pipeline to legacy-pipeline
#48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, adjust `vars.groovy` to default to `versions-pipeline` instead now that we have a _lot_ more that are converted than we have that aren't.
tianon
commented
Oct 27, 2025
Comment on lines
26
to
32
| ['ghost', [ | ||
| 'pipeline-script': 'update.sh/legacy-pipeline.groovy', | ||
| 'env': 'GHOST_VERSION', | ||
| 'otherEnvs': [ | ||
| ['ghost-cli', 'GHOST_CLI_VERSION'], | ||
| ], | ||
| ]], |
Member
Author
There was a problem hiding this comment.
docker-library/ghost#456 will make this nice and clean too 👀
Suggested change
| ['ghost', [ | |
| 'pipeline-script': 'update.sh/legacy-pipeline.groovy', | |
| 'env': 'GHOST_VERSION', | |
| 'otherEnvs': [ | |
| ['ghost-cli', 'GHOST_CLI_VERSION'], | |
| ], | |
| ]], | |
| ['ghost', []], |
tianon
commented
Oct 27, 2025
| 'pipeline-script': 'update.sh/versions-pipeline.groovy', | ||
| ]], | ||
|
|
||
| // versionless |
Member
Author
There was a problem hiding this comment.
(This diff is a little bit more annoying than it might otherwise have been because I moved these up since "versionless" doesn't really have as much meaning as it did now that we don't scrape version numbers from metadata stored here.)
yosifkit
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, adjust
vars.groovyto default toversions-pipelineinstead now that we have a lot more that are converted than we have that aren't.(This was actually @yosifkit's idea a few days ago - I just did the work before he did 😂)