fix: non-ASCII cleanup and backup robustness#9
Merged
doanbactam merged 1 commit intomasterfrom Apr 3, 2026
Merged
Conversation
- Remove emoji and Unicode symbols (em dash, box drawing, checkmarks) from source code files for cross-terminal compatibility - Deduplicate fileExists() in cli.ts by reusing pathExists() utility - Fix TOCTOU anti-pattern in backup/restore logic (try/catch instead of pre-check existence) - Extract HOOK_BACKUP_EXT constant to eliminate magic string - Replace inline fs.access checks in uninstall.ts with pathExists()
doanbactam
force-pushed
the
fix/hook-backup-before-overwrite
branch
from
540d786 to
207ba59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fileExists()incli.tsby reusing the sharedpathExists()utility frompaths.tsHOOK_BACKUP_EXTconstant to replace.bakmagic string scattered across install/uninstallfs.access().then().catch()patterns inuninstall.tswith the existingpathExists()utilityTest plan
bun test— 38/38 tests passnpm run build— dist rebuilt successfullygrep -P '[^\x00-\x7F]'— no remaining non-ASCII in source filesnpx nococli install+uninstallon a repo with an existing non-nococli hook