Stop repeating unsupported extension UI warnings#202
Merged
Conversation
A pi extension may send the same widget update many times while it is doing ordinary work. Emacs still cannot render that widget, and the user should still be told that once; telling them on every update only makes the minibuffer unusable. Remember which unsupported extension UI methods have already been reported for the current pi session, and forget that record when the session changes. Fire-and-forget UI requests such as setWidget and setTitle are not answered with fake cancellations; unknown or dialog-like requests still get cancellation responses so extensions do not hang.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pi extension may send the same widget update many times while it is doing ordinary work. Emacs still cannot render that widget, and the user should still be told that once; telling them on every update only makes the minibuffer unusable.
Remember which unsupported extension UI methods have already been reported for the current pi session, and forget that record when the session changes. Fire-and-forget UI requests such as setWidget and setTitle are not answered with fake cancellations; unknown or dialog-like requests still get cancellation responses so extensions do not hang.