Skip to content

feat: add T (select thinking) and h (hide thinking) to transient menu#190

Closed
DevGiuDev wants to merge 1 commit into
dnouri:masterfrom
DevGiuDev:feat/thinking-menu-options
Closed

feat: add T (select thinking) and h (hide thinking) to transient menu#190
DevGiuDev wants to merge 1 commit into
dnouri:masterfrom
DevGiuDev:feat/thinking-menu-options

Conversation

@DevGiuDev
Copy link
Copy Markdown
Contributor

  • T: select thinking level from list via completing-read (off, minimal, low, medium, high, xhigh) using set_thinking_level RPC
  • h: toggle hide-thinking — hides streaming thinking blocks client-side, shows placeholder 'Thinking...' label instead
  • Header-line and transient description show [hidden] when active
  • t renamed to 'thinking (cycle)', T to 'Thinking (list)'

- T: select thinking level from list via completing-read (off, minimal,
  low, medium, high, xhigh) using set_thinking_level RPC
- h: toggle hide-thinking — hides streaming thinking blocks client-side,
  shows placeholder 'Thinking...' label instead
- Header-line and transient description show [hidden] when active
- t renamed to 'thinking (cycle)', T to 'Thinking (list)'
@dnouri
Copy link
Copy Markdown
Owner

dnouri commented Apr 15, 2026

I implemented the feature where you can select the thinking level in #191. It replaces the old t binding because that's no longer useful (however you can still cycle by using the mouse), and because T was already taken.

As for the hide thinking, I like the idea, but I'd like the implementation to be more like a real hide with the ability to toggle hiding with true round-trip and without loss of thinking text, maybe a bit similar to how we're toggling long outputs today.

@DevGiuDev
Copy link
Copy Markdown
Contributor Author

You mean to have thinking collapsed? This is better than my solution of course

@dnouri
Copy link
Copy Markdown
Owner

dnouri commented Apr 17, 2026

You mean to have thinking collapsed? This is better than my solution of course

Yes, exactly.

@dnouri
Copy link
Copy Markdown
Owner

dnouri commented Apr 21, 2026

@DevGiuDev Do you wanna give #195 a try? It implements the collapsable "hide thinking".

@DevGiuDev
Copy link
Copy Markdown
Contributor Author

Ok, will try it later.

dnouri added a commit that referenced this pull request Apr 27, 2026
Keep live thinking visible while pi is still working, but collapse completed thinking into a short line once the answer lands. Let me press TAB to open just one completed-thinking block, use C-c C-p h to show or hide completed thinking for this chat, and use C-c C-p H to choose the default for new chats. Keep tool output, custom messages, and window positions stable while toggling, and make reload, resume, and fork come back to the right session instead of letting stale history wander back in.

This follows the same motivation as #190—getting noisy thinking out of the way—but does it without deadening the live stream: only completed thinking is folded away.
@dnouri
Copy link
Copy Markdown
Owner

dnouri commented Apr 27, 2026

@DevGiuDev I've now merged #195 and hope that it resolves this issue adequately. Let me know when you get a chance to test it. I would love to hear how it works for you.

@dnouri dnouri closed this Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants