fix: return a clear error when a transformation read 500s - #17
Open
MarcusSchoelzel wants to merge 1 commit into
Open
fix: return a clear error when a transformation read 500s#17MarcusSchoelzel wants to merge 1 commit into
MarcusSchoelzel wants to merge 1 commit into
Conversation
GET /sap/bw/modeling/trfn/{name}/m returns HTTP 500 "BW Model
serialization failed" (CL_RSO_RES_TRFN -> get_xml_from_db) for
transformations the modeling serializer cannot represent — typically ones
with start/end/expert ABAP routines or legacy rule types. This is a
permanent SAP modeling limitation (Eclipse BWMT shows the same), not a
transient error. bwGetTransformation() surfaced the raw 500 plus the XML
body verbatim.
Catch the serialization 500 and throw a concise, actionable error that
points to SAP GUI (RSTRAN). Any other error is re-thrown unchanged.
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Owner
|
Thanks for the PR! I'll verify this with a transformation that has ABAP routines in our dev system before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /sap/bw/modeling/trfn/{name}/mreturns HTTP 500 "BW Model serialization failed" (CL_RSO_RES_TRFN → get_xml_from_db) for transformations the modeling serializer cannot represent — typically ones with start/end/expert ABAP routines or legacy rule types. This appears to be a permanent SAP modeling limitation (Eclipse BWMT shows the same on such transformations), not a transient error.bwGetTransformation()surfaced the raw 500 plus the full XML body.Fix: catch the "serialization failed" 500 and throw a concise, actionable error pointing to SAP GUI (RSTRAN). Any other error is re-thrown unchanged.
Reviewer note: please confirm the "permanent SAP limitation" characterization — it's the AI's inference from observed behavior, not from an SAP Note.
Testing:
npm run buildpasses.