-
-
Notifications
You must be signed in to change notification settings - Fork 302
feat: add support for 1.21.11 #3578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/main/java/com/comphenix/protocol/injector/netty/channel/NettyChannelProxy.java
Outdated
Show resolved
Hide resolved
src/main/java/com/comphenix/protocol/injector/netty/channel/NettyChannelProxy.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for Minecraft version 1.21.11 (Mounts of Mayhem update) by updating dependencies, API mappings, and handling various package/class renames in the Minecraft codebase.
Key Changes:
- Updated Minecraft version from 1.21.10 to 1.21.11 with corresponding CraftBukkit package version changes (v1_21_R6 → v1_21_R7)
- Updated multiple dependencies including Netty, JUnit, Mockito, Kyori Adventure, and ByteBuddy
- Adapted to Minecraft API changes including class renames (ResourceLocation → Identifier), package relocations, and new packet/enum types
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| build.gradle.kts | Updated Minecraft version to 1.21.11 and bumped dependencies (Netty, JUnit, Gradle plugins, ByteBuddy, Kyori Adventure, Mockito) |
| src/main/java/com/comphenix/protocol/utility/MinecraftVersion.java | Added v1_21_11 version constant and updated LATEST to reference it |
| src/main/java/com/comphenix/protocol/utility/MinecraftReflection.java | Updated class resolution to handle renamed Minecraft classes (Identifier, new fallback paths) |
| src/main/java/com/comphenix/protocol/wrappers/EnumWrappers.java | Added STAB enum value to PlayerDigType and updated SoundCategory class resolution |
| src/main/java/com/comphenix/protocol/PacketType.java | Added MountScreenOpen as new packet name for OPEN_WINDOW_HORSE |
| src/main/java/com/comphenix/protocol/utility/ZeroBuffer.java | Implemented new ByteBuf interface methods for Netty compatibility (ByteProcessor, FileChannel, CharSequence operations) |
| src/main/java/com/comphenix/protocol/injector/netty/channel/NettyEventLoopProxy.java | Added register(ChannelPromise) method override for Netty compatibility |
| src/main/java/com/comphenix/protocol/injector/netty/channel/NettyChannelProxy.java | Added id() and hasAttr() method overrides for Netty compatibility |
| src/test/java/com/comphenix/protocol/utility/MinecraftReflectionTestUtil.java | Updated test target version to 1.21.11 and package version to v1_21_R7 |
| src/test/java/com/comphenix/protocol/BukkitInitialization.java | Updated CraftBukkit imports to v1_21_R7, replaced ResourceLocation with Identifier, and updated ReloadableServerResources call to use LevelBasedPermissionSet |
| src/test/java/com/comphenix/protocol/wrappers/WrappedStreamCodecTests.java | Updated CraftBukkit imports from v1_21_R6 to v1_21_R7 |
| src/test/java/com/comphenix/protocol/wrappers/WrappedDataWatcherTest.java | Updated CraftBukkit imports and ThrownEgg package path to reflect Minecraft's class reorganization |
| src/test/java/com/comphenix/protocol/wrappers/WrappedComponentStyleTest.java | Updated JSON field order assertion and removed resolved TODO comment |
| src/test/java/com/comphenix/protocol/wrappers/WrappedBlockDataTest.java | Updated CraftBukkit imports from v1_21_R6 to v1_21_R7 |
| src/test/java/com/comphenix/protocol/wrappers/WrappedAttributeTest.java | Replaced ResourceLocation with Identifier throughout the test |
| src/test/java/com/comphenix/protocol/wrappers/AutoWrapperTest.java | Replaced ResourceLocation with Identifier in test cases |
| src/test/java/com/comphenix/protocol/utility/MinecraftReflectionTest.java | Updated CraftBukkit imports from v1_21_R6 to v1_21_R7 |
| src/test/java/com/comphenix/protocol/injector/EntityUtilitiesTest.java | Updated CraftBukkit imports from v1_21_R6 to v1_21_R7 |
| src/test/java/com/comphenix/protocol/events/PacketContainerTest.java | Updated imports: replaced ResourceLocation with Identifier, updated Cat/Frog variant package paths, and cleaned up unused imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
great work, thank you! |
No description provided.