Preserve url parameter from POST body; don't append nil referer#67
Open
dmolesUC wants to merge 2 commits intodlindahl:masterfrom
Open
Preserve url parameter from POST body; don't append nil referer#67dmolesUC wants to merge 2 commits intodlindahl:masterfrom
url parameter from POST body; don't append nil referer#67dmolesUC wants to merge 2 commits intodlindahl:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we were looking for
request.params['url'], and assuming that if it was present, it would be in the original query string and OmniAuth would already have appended it to the callback URL.With this change, the behavior for a
urlparameter in the query string (Rack::Request#GET) is unchanged. However, if there is nourlparameter in the query string, but there is one in the form body (Rack::Request#POST), we transfer the value from the form body to the callback URL query string.As a fallback, we use the HTTP
Referervalue, just as OmniAuth does for theoriginparameter. However, we were previously appending it unconditionally, whether or not it was actually present (as it often isn’t, for various reasons), resulting in an emptyurlquery parameter in the callback URL. With this change, we now only append the referrer if non-nil.Fixes #66.