Open
Conversation
chandrasekarsrin
requested changes
Sep 22, 2021
| 1. Install Java SE SDK 11 on your system: https://java.com/en/download/help/download_options.html | ||
| 2. Compile the app: | ||
|
|
||
| ```javac src/com/sample/HelloWorld.java``` |
Collaborator
There was a problem hiding this comment.
it says maven example but why are we using javac to build the code. i would expect to use 'mvn clean install' command here.
| timeoutInSeconds: 10000 | ||
| command: | | ||
| cd src/com/sample/ | ||
| javac HelloWorld.java |
Collaborator
There was a problem hiding this comment.
we should be using mvn rather than java here.
| FROM openjdk:8-alpine | ||
| COPY ./src/com/sample/HelloWorld.class /app/com/sample/HelloWorld.class | ||
| WORKDIR /app | ||
| ENTRYPOINT ["java", "com.sample.HelloWorld"] No newline at end of file |
Collaborator
There was a problem hiding this comment.
docker file also should change for maven.
| runAs: root | ||
| - type: Command | ||
| name: "Building JAR" | ||
| timeoutInSeconds: 10000 |
Collaborator
There was a problem hiding this comment.
I think we are doing mvn here. then ideally we should be removing the other build spec file.
| command: | | ||
| mvn clean install | ||
| onFailure: | ||
| - type: Command |
Collaborator
There was a problem hiding this comment.
we should also do a docker build here to have a complete example.
chandrasekarsrin
approved these changes
Sep 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.