Skip to content

Conversation

@pbackus
Copy link
Contributor

@pbackus pbackus commented Nov 20, 2025

To reduce the number of template instantiations per call, this change replaces the original match-based implementations of has, get, and tryGet with specialized implementations that inline both the matching and the handlers into a single function body.

To reduce the number of template instantiations per call, this change
replaces the original match-based implementations of has, get, and
tryGet with specialized implementations that inline both the matching
and the handlers into a single function body.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @pbackus! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10903"

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you have run the numbers for this?

@pbackus
Copy link
Contributor Author

pbackus commented Nov 20, 2025

I got the following results, using a SumType with 5 members, counting instantiations with -vtemplates, and looking only at templates from std/sumtype.d:

  • has:
    • Before: 49 instantiations per call (27 distinct)
    • After: 4 instantiations per call (2 distinct)
  • tryGet
    • Before: 54 instantiations per call (32 distinct)
    • After: 12 instantiations per call (8 distinct)

I assume get is the same as tryGet because they share their implementation.

I haven't attempted to measure time or memory consumption yet. If we want those numbers, let me know, and I'll do so.

@thewilsonator thewilsonator merged commit 775fd93 into dlang:master Nov 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants