fix: Accept mixed-case owner names

README.md

@@ -7,7 +7,9 @@ A GitHub App built with [Probot](https://github.com/probot/probot) for approving
 
 ![image](https://user-images.githubusercontent.com/4306809/50573484-13a0a100-0dd5-11e9-8ef3-aad5069e83e3.png)
 
-## Setup
+## Setup (for contributors)
+These are instructions for contributing code to the bot. If you just want to run the bot, skip to
+the Configure section below.
 
 ```sh
 # Install dependencies
@@ -61,7 +63,9 @@ jobs:
 
 ## Configuration
 
-In order to use the bot, the config file should be provided. Config file should be defined in your repository. Config file is the yml file with the path `.github/autoapproval.yml`. The file should have at least 3 mandatory entries: `from_owner`, `required_labels` and `apply_labels`.
+In order to use the bot, the config file should be provided. Config file should be defined in your
+repository. Config file is the yml file with the path `.github/autoapproval.yml`. The file should
+have at least 3 mandatory entries: `from_owner`, `required_labels`, `apply_labels`, and `blacklisted_labels`.
 
 ---
 
@@ -98,7 +102,7 @@ If the value set to `one_of`, then it's enough to have only of the `required_lab
 ---
 
 ### blacklisted_labels
-
+**mandatory**
 Defines the list of labels on PR, which will prevent the PR from being automatically approved. For example:
 ```
 blacklisted_labels:

src/index.ts

@@ -1,5 +1,5 @@
-import { Probot, Context } from 'probot'
 import { PullRequestEvent, PullRequestReviewEvent } from '@octokit/webhooks-types'
+import { Context, Probot } from 'probot'
 
 module.exports = (app: Probot) => {
   app.on(['pull_request.opened', 'pull_request.reopened', 'pull_request.labeled', 'pull_request.edited', 'pull_request_review'], async (context) => {
@@ -39,8 +39,9 @@ module.exports = (app: Probot) => {
       }
     }
 
-    // reading pull request owner info and check it with configuration
-    const ownerSatisfied = config.from_owner.length === 0 || config.from_owner.includes(pr.user.login)
+    // reading pull request owner info and check it with configuration (case insensitive)
+    const lowerLogin = pr.user.login.toLowerCase()
+    const ownerSatisfied = config.from_owner.length === 0 || config.from_owner.some((owner: string) => owner.toLowerCase() === lowerLogin)
 
     // reading pull request labels and check them with configuration
     let requiredLabelsSatisfied
@@ -75,7 +76,7 @@ module.exports = (app: Probot) => {
       }
     } else {
       // one of the checks failed
-      context.log('Condition failed! \n - missing required labels: %s\n - PR owner found: %s', requiredLabelsSatisfied, ownerSatisfied)
+      context.log('Condition failed! \n - has required labels: %s\n - PR owner found: %s', requiredLabelsSatisfied, ownerSatisfied)
     }
   })
 }

test/index.test.ts

@@ -140,6 +140,32 @@ describe('Autoapproval bot', () => {
     expect(nock.isDone()).toBeTruthy()
   })
 
+  test('PR has expected mixed-case owner -> will be approved', async () => {
+    const payload = require('./fixtures/pull_request.opened.json')
+    const config = 'from_owner:\n  - dKHMelenko\nrequired_labels:\n  - merge\nblacklisted_labels: []\napply_labels: []'
+    const reviews = require('./fixtures/pull_request_reviews_empty.json')
+
+    nock('https://api.github.com')
+      .get('/repos/dkhmelenko/autoapproval/contents/.github%2Fautoapproval.yml')
+      .reply(200, config)
+
+    nock('https://api.github.com')
+      .get('/repos/dkhmelenko/autoapproval/pulls/1/reviews')
+      .reply(200, reviews)
+
+    nock('https://api.github.com')
+      .post('/repos/dkhmelenko/autoapproval/pulls/1/reviews', (body: any) => {
+        return body.event === 'APPROVE'
+      })
+      .reply(200)
+
+    // Receive a webhook event
+    await probot.receive({ name: 'pull_request', payload })
+
+    await new Promise(process.nextTick) // Don't assert until all async processing finishes
+    expect(nock.isDone()).toBeTruthy()
+  })
+
   test('PR has multiple required labels and expected owner -> will be approved', async () => {
     const payload = require('./fixtures/pull_request_opened_multiple_labels.json')
     const config = 'from_owner:\n  - dkhmelenko\nrequired_labels:\n  - merge\n  - merge2\nblacklisted_labels: []\napply_labels: []'