Create guide for seeking audio resource #1483
Conversation
Create guide for seeking audio resource.
|
ESLint is kinda... |
|
I'm afraid but could you run ESLint one more time? I have fixed all of the error and warning. |
|
Thanks bro |
Co-authored-by: megatank58 <[email protected]>
Co-authored-by: megatank58 <[email protected]>
|
Hey I'm really sorry but could you run ESLint one more time |
|
Sorry could you re-run ESLint check (Why ESLint says readability is unnecessary) |
|
Thank you so much for running so many ESLint check |
|
Personally I'd be against having this as its own article. A more general |
|
@ducktrshessami Yeah, that's true enough, but honestly, this will eventually fit in voice section. Because adding content like this in popular topics does not related to discord.js directly. Adding this in voice section (because u know how do you use these things in other part of discord.js bot developing) will be better in my opinion. |
There was a problem hiding this comment.
I wasn't referring to the "Popular Topics" section of the main guide. I agree that a guide about prism-media is more relevant in the Voice guide. I am simply opposed to this as a standalone article. A new "Popular Topics" section can be added since this isn't directly related to @discordjs/voice. If you do agree I'd definitely like to see this rewritten before being merged.
I see I got it. So you mean, like creating new 'Popular Topics' in voice MD and referring this kind of articles in it? |
Jiralite
requested review from
ducktrshessami and
vladfrangu
and removed request for
ducktrshessami
original PR: discordjs/guide#1483
|
thank you for the contribution and sorry for the lack of action - i have ported this guide to the next iteration of the guide under the main repository |
|
Thank you @almostSouji ! |
* chore: remove await wait placeholder prefer using an explanatory placeholder rather than this artificial example original issue: https://github.com/discordjs/guide/issues/1360 * chore: remove implicit grant guide and add disclaimer issue: https://github.com/discordjs/guide/issues/1370/ pr: discordjs/guide#1543 * chore(sharding): improve broadcast sample and use of context argument original PR: discordjs/guide#1624 * feat: add page about setup with proxy original PR: discordjs/guide#1623 * chore: clarify hiding of commands original PR: discordjs/guide#1617 * feat(voice): seeking original PR: discordjs/guide#1483 * chore(oauth2): typo * chore: align with rest of the guide remove abstraction layers in ws proxy handling in favour of directly setting globals * chore: branding over grammar * Apply suggestions from code review Co-authored-by: Qjuh <[email protected]> * chore: remove now obsolete example explanation from comments --------- Co-authored-by: Qjuh <[email protected]>
Create a guide for seeking audio resources.
Please describe the changes this PR makes and why it should be merged:
Explain how to seek audio resources with raw discord.js and @discordjs/voice
Many questions about seeking are posted on discord.js guild, and there's no guide about seeking. So I created this.