Defer creating component provider list until we have to and optimistically create it on a separate thread #79
+41
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannojg
approved these changes
Jul 15, 2025
Comment on lines
+30
to
+31
| void ComponentDescriptorRegistry::addMultipleAsync( | ||
| std::vector<ComponentDescriptorProvider> providers) const { |
There was a problem hiding this comment.
NIT: do we want to make this a rvalue reference && to make obvious that the function wants to take ownvership?
| @@ -15,6 +15,7 @@ | |||
| #include <react/renderer/core/ComponentDescriptor.h> | |||
| #include <react/renderer/core/InstanceHandle.h> | |||
| #include <react/utils/ContextContainer.h> | |||
| #include <thread> | |||
There was a problem hiding this comment.
NIT: as we only need that in the implementaton lets move it to the cpp file to keep the header clean?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
Test Plan: