-
-
Notifications
You must be signed in to change notification settings - Fork 247
Label and Select Menu support for Modals #1377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
valzargaming
wants to merge
19
commits into
master
Choose a base branch
from
modal-select-menu
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use top-level label component instead
It's valid to pass a Part instead of a Builder
It's only makes sense to restrict the usage to this context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for Discord's new Label component and updates the modal component structure to reflect Discord's latest standards. The main changes include the addition of the
Label
component, deprecation ofActionRow
usage in modals, and updates to select menus and text inputs to support modal requirements. These changes modernize the component system and improve compatibility with Discord's evolving API.Component System Updates
Label
component as a top-level container for modals, including its implementation in both builders (Label.php
) and message parts (Label.php
). [1] [2]TYPE_LABEL
in the component type constants and mapping, enabling its use throughout the codebase. [1] [2]Modal Structure Changes
ActionRow
as a top-level container in modals; documentation and code comments now recommend usingComponent::Label
instead. [1] [2]Label
andActionRow
containers when processing modal submissions.Select Menu and Text Input Enhancements
setRequired
onStringSelect
. [1] [2] [3]TextInput
for modals, making it optional and updating constructors and serialization accordingly. [1] [2] [3] [4] [5]Minor Improvements