ci: run integration tests on all PRs, not just clojure/** changes#1739
Open
dimitri wants to merge 1 commit into
Open
ci: run integration tests on all PRs, not just clojure/** changes#1739dimitri wants to merge 1 commit into
dimitri wants to merge 1 commit into
Conversation
The workflow already includes v3 matrix targets (mssql-v3, mysql-v3, etc.) alongside v4. Restricting pull_request to clojure/** paths meant v3-only PRs (src/**) never triggered it, yet branch protection expected those check names — requiring --admin to force-merge. Remove the paths filter from pull_request so the full matrix runs on every PR. Keep the paths filter on push so routine non-code pushes to main (docs, CI tweaks) don't burn the full suite unnecessarily.
f2d2e68 to
52870f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow already includes v3 matrix targets (
mssql-v3,mysql-v3, etc.) alongside v4. Restrictingpull_requesttoclojure/**paths meant v3-only PRs (src/**) never triggered it, yet branch protection expected those check names — requiring--adminto force-merge (#1738 being the immediate example).Change
pull_request: drop thepathsfilter entirely — every PR now runs the full matrix.push: keepsrc/**+clojure/**+ the workflow file itself, so routine non-code pushes to main do not burn the full suite.No test code changed.