Add verify-full to supported SSL modes for postgres#1704
Open
ragne wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to use the tool with databricks lakebase and it seems like pgloader doesn't support SNI with any of the existing
sslmodevalues.Underlying
Postmodernlibrary seem to support SNI with mode set to:fulland it looks like in the pgloader code only the parsing bits need to be fixed.The only problem I see is that semantics are different from what
libpqdoes.libpq sends SNI by default through the sslsni connection parameter, independently of the selected sslmode. In libpq, sslmode=require still uses TLS and sends SNI by default; sslmode=verify-full additionally verifies the server certificate hostname.
But cl-postgres from Postmodern appears to pass the hostname to the TLS layer only for the :full SSL mode.
Please take a look and let me know your thoughts.