Skip to content

Comments

fix(g1): add rerun bridge to G1 primitive blueprint#1333

Closed
spomichter wants to merge 1 commit intodevfrom
fix/g1-rerun-bridge
Closed

fix(g1): add rerun bridge to G1 primitive blueprint#1333
spomichter wants to merge 1 commit intodevfrom
fix/g1-rerun-bridge

Conversation

@spomichter
Copy link
Contributor

The G1 blueprint was missing the rerun bridge entirely — only had websocket_vis + foxglove_bridge. This adds:

  • rerun_config with LCM pubsubs, visual overrides (camera_info, global_map, costmap), and a G1-shaped wireframe box
  • match global_config.viewer_backend block (same pattern as Go2) to wire up rerun/rerun-web/foxglove

Fixes: rerun-web viewer opening blank when running G1 sim.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 21, 2026

Greptile Summary

Adds rerun bridge support to the G1 primitive blueprint, following the same pattern used in the Go2 blueprints. The change restructures the blueprint to support multiple viewer backends (foxglove, rerun, rerun-web) via a match statement on global_config.viewer_backend.

Key additions:

  • rerun_config dict with LCM pubsub, visual overrides for camera_info/global_map/costmap, and a G1-shaped wireframe box
  • Viewer backend switching logic that mirrors the Go2 implementation
  • Refactored blueprint structure with _base and _with_vis intermediates

One issue found: the camera image topic path in the rerun config doesn't match the LCM transport mapping.

Confidence Score: 4/5

  • Safe to merge after fixing the camera topic path mismatch
  • The implementation correctly follows the established Go2 pattern for viewer backend switching. The rerun_config structure is appropriate with proper visual overrides and static elements. However, there's a topic path mismatch between the rerun camera_info visual override (/world/color_image) and the actual LCM transport (/g1/color_image) that will prevent the camera feed from appearing in the rerun viewer.
  • Fix the image topic path in line 41 to match the transport mapping

Important Files Changed

Filename Overview
dimos/robot/unitree/g1/blueprints/primitive/uintree_g1_primitive_no_nav.py Adds rerun bridge support with LCM pubsub, visual overrides, and viewer backend switching. Minor topic path mismatch in camera_info visual override.

Last reviewed commit: 7d9e668

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

"pubsubs": [LCM(autoconf=True)],
"visual_override": {
"world/camera_info": lambda camera_info: camera_info.to_rerun(
image_topic="/world/color_image",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image topic path /world/color_image doesn't match the transport mapping /g1/color_image (line 125)

Suggested change
image_topic="/world/color_image",
image_topic="/g1/color_image",

@spomichter
Copy link
Contributor Author

Closing in favor of #1334 which achieves the same fix with a smaller, cleaner diff.

@spomichter spomichter closed this Feb 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant