fix(g1): add rerun bridge to G1 primitive blueprint#1333
Closed
spomichter wants to merge 1 commit intodevfrom
Closed
fix(g1): add rerun bridge to G1 primitive blueprint#1333spomichter wants to merge 1 commit intodevfrom
spomichter wants to merge 1 commit intodevfrom
Conversation
Contributor
Greptile SummaryAdds rerun bridge support to the G1 primitive blueprint, following the same pattern used in the Go2 blueprints. The change restructures the blueprint to support multiple viewer backends (foxglove, rerun, rerun-web) via a match statement on Key additions:
One issue found: the camera image topic path in the rerun config doesn't match the LCM transport mapping. Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 7d9e668 |
| "pubsubs": [LCM(autoconf=True)], | ||
| "visual_override": { | ||
| "world/camera_info": lambda camera_info: camera_info.to_rerun( | ||
| image_topic="/world/color_image", |
Contributor
There was a problem hiding this comment.
image topic path /world/color_image doesn't match the transport mapping /g1/color_image (line 125)
Suggested change
| image_topic="/world/color_image", | |
| image_topic="/g1/color_image", |
Contributor
Author
|
Closing in favor of #1334 which achieves the same fix with a smaller, cleaner diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The G1 blueprint was missing the rerun bridge entirely — only had websocket_vis + foxglove_bridge. This adds:
rerun_configwith LCM pubsubs, visual overrides (camera_info, global_map, costmap), and a G1-shaped wireframe boxmatch global_config.viewer_backendblock (same pattern as Go2) to wire up rerun/rerun-web/foxgloveFixes: rerun-web viewer opening blank when running G1 sim.