Fix N+1 Query Issue in Vets Endpoint-created-by-agentic #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

shaykeren wants to merge 3 commits into main from fix-n-plus-1-vets-endpoint-20240312-created-by-agentic

shaykeren commented Jul 23, 2025

This PR addresses the N+1 query performance issue in the Vets endpoint by implementing the following changes:

Changed FetchType from EAGER to LAZY for specialties in Vet entity
Added NamedEntityGraph for efficient fetching of Vet specialties
Updated VetRepository to use EntityGraph annotation
Added composite index on vet_specialties table for improved query performance

These changes will:

Prevent unnecessary queries when specialties are not needed
Optimize fetching when specialties are needed using join fetch
Improve query performance with proper indexing

Testing:

The changes maintain existing functionality while improving performance
The EntityGraph ensures efficient loading of specialties when needed
The composite index will improve join performance

Related Issue: #e8efc2b4-5f5e-11f0-bbd9-0242ac160009

shaykeren added 3 commits

July 23, 2025 15:32


          fix: Change specialties fetch type to LAZY and add EntityGraph

1f60ca6


          fix: Add EntityGraph support for efficient fetching

0b9ef93


          fix: Add composite index on vet_specialties table

85ec4ca

shaykeren mentioned this pull request

N+1 Query Performance Issue in Vets Endpoint-created-by-agentic #82

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet