Skip to content

Fix Monitor Service Error Handling-created-by-agentic #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shaykeren
Copy link

This PR addresses the critical IllegalStateException failures in the MonitorService by:

  1. Adding configurable error injection for testing purposes
  2. Implementing circuit breaker pattern to prevent cascading failures
  3. Adding proper error handling and recovery mechanisms
  4. Improving OpenTelemetry instrumentation

Changes:

  • Added configuration for error injection testing
  • Implemented circuit breaker pattern with failure counting and recovery
  • Added better error handling with recovery attempts
  • Enhanced OpenTelemetry instrumentation for better monitoring

Testing:

  • The service will now gracefully handle errors
  • Circuit breaker prevents cascading failures
  • Error injection can be controlled via configuration
  • Better observability through enhanced instrumentation

This fixes the critical failures reported in the monitoring endpoint while maintaining the ability to test error scenarios in a controlled way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant