Add support for windows named pipe monitor #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to the existing unix sockets
connorkuehl
requested changes
Aug 26, 2022
There was a problem hiding this comment.
Hi @afbjorklund, thank you for the patch 🙂 Please rebase this PR against the tip of master and then I think it'll be good to merge.
|
Unfortunately qemu never started up properly when using pipes, had to switch to "null" just to make it boot... |
|
No worries! Take your time. |
|
See PR for context: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the existing unix sockets
I think it would be possible to implement this for Unix as well, using
mkfifoand a suitable Monitor