add reserved ipv6 support #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnegi-digitalocean
force-pushed
the
add-support-reserved-ipv6
branch
from
ebd2476 to
fd50afc
Compare
vnegi-digitalocean
force-pushed
the
add-support-reserved-ipv6
branch
from
fd50afc to
32ee4dd
Compare
vnegi-digitalocean
changed the title
imaskm
reviewed
Jan 16, 2025
imaskm
reviewed
Jan 16, 2025
vnegi-digitalocean
force-pushed
the
add-support-reserved-ipv6
branch
from
d0f52c7 to
d30c69a
Compare
bentranter
requested changes
Jan 21, 2025
Member
bentranter
left a comment
bentranter
left a comment
There was a problem hiding this comment.
Two nitpicks, but overall LGTM. I'll merge after the two pieces of feedback are addressed. Nicely done!
Co-authored-by: Ben Tranter <[email protected]>
Co-authored-by: Ben Tranter <[email protected]>
|
Decided to merge this PR around the end of Feb. |
bentranter
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.