Skip to content

Conversation

@mielvds
Copy link
Collaborator

@mielvds mielvds commented Dec 12, 2025

This PR removes some of 'old-style' python code and fixes linter issues:

  • remove the need for the cmp() function wrt to sorting
  • use isinstance() and is to do type checking (instead of for instance type(x) == bool)
  • change not X in Y to X not in Y
  • always raise specific error

@mielvds mielvds marked this pull request as ready for review December 16, 2025 10:54
Copy link
Member

@davidlehn davidlehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Thanks for cleanup.
  • I think much this style was originally due to manual js to py conversion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants