Open
Conversation
dlongley
approved these changes
Mar 7, 2026
- Use `eslint@9`. - Use `@digitalbazaar/eslint-config@8`.
- Node version should be at least 18.x now. - 18.x already implied by other dependencies.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
- Add basic self test. - Test on Node.js >=20.
- Removing code that appears to be old. There were no tests here earlier and this array also gets cleared elsewhere before use.
dlongley
approved these changes
Mar 29, 2026
Member
dlongley
left a comment
dlongley
left a comment
There was a problem hiding this comment.
Approving, but please see my one comment. Thanks!
| config.mocha.tests = []; | ||
|
|
||
| // built-in tests | ||
| config.mocha.tests.push(path.join(__dirname, '..', 'tests')); |
Member
There was a problem hiding this comment.
Not sure what this might do to existing use / if it's ok.
Member
Author
There was a problem hiding this comment.
361cc6a
As noted in the commit, I couldn't determine what that was for. It was adding the ../tests/ dir of this project which didn't previously exist. And it appears to be wiped out anyway in other code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.