Skip to content

Use shutdown() to exit on success.#25

Merged
davidlehn merged 2 commits intomainfrom
use-shutdown
Apr 6, 2026
Merged

Use shutdown() to exit on success.#25
davidlehn merged 2 commits intomainfrom
use-shutdown

Conversation

@davidlehn
Copy link
Copy Markdown
Member

Comment thread CHANGELOG.md Outdated
@davidlehn
Copy link
Copy Markdown
Member Author

This was written quite a while ago. It was working for the use case I had. It really could use more testing before a release.
I suspect it will work fine in most cases but would be good to check. It's possible the handlers that were never called before, which now will be, could cause edge case issues.

- Use `bedrock.shutdown()` for an orderly exit on success.
- The previous behavior was to abruptly shut down an app, even after
  testing success. Now event handlers will be called while app is
  shutting down:
  - `bedrock.stop`
  - `bedrock.stopped`
  - `bedrock.exit`
- Upgrade dependencies:
  - `chai@6`
  - `chai-as-promised@8`
- Upgrade dev dependencies:
  - `c8@11`
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.09%. Comparing base (43b6a98) to head (4157187).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   88.09%   88.09%           
=======================================
  Files           4        4           
  Lines         336      336           
=======================================
  Hits          296      296           
  Misses         40       40           
Files with missing lines Coverage Δ
lib/test.js 85.51% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b6a98...4157187. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davidlehn davidlehn merged commit ca846dd into main Apr 6, 2026
5 checks passed
@davidlehn davidlehn deleted the use-shutdown branch April 6, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants