Readme updates - #77
Open
khilscher wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the project README to improve external references and clarify commercial licensing contact details.
Changes:
- Added a “Learn more” link to the product page in the opening description.
- Updated the commercial licensing paragraph to mention FIPS 140-3 certification needs and changed the contact email.
- Minor README formatting cleanup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - **Commercial License:** | ||
| If you wish to use TrustCore SDK in a **proprietary** or **commercial** product (e.g., embedded in closed-source firmware or commercial SaaS applications), a commercial license is available under DigiCert’s [Master Services Agreement](https://www.digicert.com/master-services-agreement/) (MSA). Contact us at [sales@digicert.com](mailto:sales@digicert.com) for commercial licensing details. | ||
| If you wish to use TrustCore SDK in a **proprietary** or **commercial** product (e.g., embedded in closed-source firmware or commercial SaaS applications) or require FIPS 140-3 certification, a commercial license is available under DigiCert’s [Master Services Agreement](https://www.digicert.com/master-services-agreement/) (MSA). Contact us at [device-trust@digicert.com](mailto:device-trust@digicert.com) for commercial licensing details. |
There was a problem hiding this comment.
This line is intended to be part of the "Commercial License" list item, but it is not indented, so Markdown will render it as a separate paragraph rather than content under the bullet. Please indent it to match the formatting used for the "Open Source License" bullet above.
Suggested change
| If you wish to use TrustCore SDK in a **proprietary** or **commercial** product (e.g., embedded in closed-source firmware or commercial SaaS applications) or require FIPS 140-3 certification, a commercial license is available under DigiCert’s [Master Services Agreement](https://www.digicert.com/master-services-agreement/) (MSA). Contact us at [device-trust@digicert.com](mailto:device-trust@digicert.com) for commercial licensing details. | |
| If you wish to use TrustCore SDK in a **proprietary** or **commercial** product (e.g., embedded in closed-source firmware or commercial SaaS applications) or require FIPS 140-3 certification, a commercial license is available under DigiCert’s [Master Services Agreement](https://www.digicert.com/master-services-agreement/) (MSA). Contact us at [device-trust@digicert.com](mailto:device-trust@digicert.com) for commercial licensing details. |
|
|
||
| > [!NOTE] | ||
| > DigiCert is in the process of completely open-sourcing the code under the AGPL v3 license to support transparency, collaboration, and developer accessibility, while maintaining commercial licensing for commercial and proprietary use. Code will be open-sourced on a per-module basis and progress on which modules have been released can be tracked in the related [Github Project](https://github.com/orgs/digicert/projects/31). | ||
| > DigiCert is in the process of completely open-sourcing the code under the AGPL v3 license to support transparency, collaboration, and developer accessibility, while maintaining commercial licensing for commercial and proprietary use. Code will be open-sourced on a per-module basis and progress on which modules have been released can be tracked in the related [Github Project](https://github.com/orgs/digicert/projects/31). |
There was a problem hiding this comment.
The link label uses "Github" capitalization. GitHub’s brand capitalization is "GitHub", and the README already uses "GitHub" elsewhere (e.g., "GitHub issue" below). Please update the link text to "GitHub Project" for consistency.
Suggested change
| > DigiCert is in the process of completely open-sourcing the code under the AGPL v3 license to support transparency, collaboration, and developer accessibility, while maintaining commercial licensing for commercial and proprietary use. Code will be open-sourced on a per-module basis and progress on which modules have been released can be tracked in the related [Github Project](https://github.com/orgs/digicert/projects/31). | |
| > DigiCert is in the process of completely open-sourcing the code under the AGPL v3 license to support transparency, collaboration, and developer accessibility, while maintaining commercial licensing for commercial and proprietary use. Code will be open-sourced on a per-module basis and progress on which modules have been released can be tracked in the related [GitHub Project](https://github.com/orgs/digicert/projects/31). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Copilot copilot@github.com