Refactor build to use public GitHub Pages SDK repo (drop auth) - #3
Merged
Merged
Conversation
The TLM Plugin SDK now lives at https://digicert.github.io/tlm-plugins-sdk-dist, a public GitHub Pages Maven repository that needs no authentication. - settings.xml: point at the new URL and remove the <servers> block that supplied GITHUB_ACTOR/GITHUB_TOKEN credentials - build.sh: drop the token-permission checks and GITHUB_ACTOR/GITHUB_USER fallback; keep the Maven build and checksum generation - build-java-sdk.yml: remove GITHUB_ACTOR/GITHUB_TOKEN from the build step (release steps keep the auto-provided GITHUB_TOKEN for the release API) - README docs: replace the PAT/read:packages auth instructions with a no-auth note and the new repository URL Applied consistently across the cert-delivery, automation, and discovery examples.
There was a problem hiding this comment.
Pull request overview
This PR updates the example plugin builds to consume the TLM Plugin SDK from the new public GitHub Pages Maven repository (https://digicert.github.io/tlm-plugins-sdk-dist), removing the need for GitHub Packages authentication across the examples.
Changes:
- Updated each example’s
settings.xmlto point at the new public Maven repo and removed the GitHub Packages<servers>credentials block. - Simplified
build.shscripts by removing GitHub token/actor validation and permission checks. - Updated docs/workflows to no longer require
GITHUB_ACTOR/GITHUB_TOKENfor dependency downloads.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates top-level SDK retrieval docs to reflect the new public Maven repo (no auth). |
| discovery/settings.xml | Points Maven at the GitHub Pages SDK repository; removes auth server config. |
| discovery/build.sh | Removes GitHub token checks; keeps Maven build + checksum generation. |
| discovery/.github/workflows/build-java-sdk.yml | Drops token env injection for the build step. |
| cert-delivery/settings.xml | Points Maven at the GitHub Pages SDK repository; removes auth server config. |
| cert-delivery/README.md | Updates setup/troubleshooting docs to remove PAT/GitHub Packages instructions. |
| cert-delivery/build.sh | Removes GitHub token checks; keeps wrapper-based build + checksums. |
| cert-delivery/.github/workflows/build-java-sdk.yml | Drops token env injection for the build step. |
| automation/settings.xml | Points Maven at the GitHub Pages SDK repository; removes auth server config. |
| automation/build.sh | Removes GitHub token checks; keeps Maven build + checksum generation. |
| automation/.github/workflows/build-java-sdk.yml | Drops token env injection for the build step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
27
to
+29
| - name: Build with Maven | ||
| run: build.sh | ||
| env: | ||
| GITHUB_ACTOR: ${{ github.actor }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
|
|
Comment on lines
27
to
+29
| - name: Build with Maven | ||
| run: build.sh | ||
| env: | ||
| GITHUB_ACTOR: ${{ github.actor }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
|
|
Comment on lines
27
to
+29
| - name: Build with Maven | ||
| run: build.sh | ||
| env: | ||
| GITHUB_ACTOR: ${{ github.actor }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
|
|
| @@ -86,4 +18,4 @@ echo "\`\`\`" >> $CHECKSUM_FILE | |||
| find . -name "*.zip" | xargs sha256sum | cut --complement -c66-68 >> $CHECKSUM_FILE | |||
| @@ -86,4 +18,4 @@ echo "\`\`\`" >> $CHECKSUM_FILE | |||
| find . -name "*.zip" | xargs sha256sum | cut --complement -c66-68 >> $CHECKSUM_FILE | |||
| @@ -86,4 +18,4 @@ echo "\`\`\`" >> $CHECKSUM_FILE | |||
| find . -name "*.zip" | xargs sha256sum | cut --complement -c66-68 >> $CHECKSUM_FILE | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TLM Plugin SDK now lives at https://digicert.github.io/tlm-plugins-sdk-dist, a public GitHub Pages Maven repository that needs no authentication.
Applied consistently across the cert-delivery, automation, and discovery examples.