Skip to content

Feature/390 dok18#421

Open
fredriknordlander wants to merge 4 commits intomainfrom
feature/390-dok18
Open

Feature/390 dok18#421
fredriknordlander wants to merge 4 commits intomainfrom
feature/390-dok18

Conversation

@fredriknordlander
Copy link
Copy Markdown
Collaborator

Pull Request Description

Please include a summary of the change and which issue is fixed or added.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes #(issue)

Checklist

  • Changes are limited to a single goal (avoid scope creep)
  • I confirm that I have read any Contribution and Development guidelines (CONTRIBUTING and DEVELOPMENT) and are following their suggestions.
  • I confirm that I wrote and/or have the right to submit the contents of my Pull Request, by agreeing to the Developer Certificate of Origin, (adding a 'sign-off' to my commits).


**Förklaring:**

Regeln förutsätter att API-specifikationen beskrivs med antingen JSON eller YAM där den regeln letar upp alla content objekt under både requestBody och responses. Om det inte är dem, så returnerar regeln ett fel i form av en varning.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"YAML" istället för "YAM"

Fundering kring frasen "Om det inte är dem, så returnerar regeln ett fel i form av en varning" - vad är "dem" i detta fall?
JSON eller YAML?


/**
* Complement rule to AME01 that manifest that payloads should either be JSON or YAML
* TODO: This rule perhaps should have severity.error instead of warn, in order to make sense between AME/DOK.18
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ska todo stå kvar här?

## Område: Dokumentation

**Täckningsgrad: 46%**
**Täckningsgrad: 52%**
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blir det inte 12 av 24 implementerade regler med denna, så 50%?

Signed-off-by: Fredrik Nordlander <fredrik.nordlander@digg.se>
Signed-off-by: Fredrik Nordlander <fredrik.nordlander@digg.se>
Signed-off-by: Fredrik Nordlander <fredrik.nordlander@digg.se>
Signed-off-by: Fredrik Nordlander <fredrik.nordlander@digg.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants