Skip to content

fix(base): revert ds-icon defining fill#5013

Merged
mimarz merged 2 commits into
mainfrom
fix-ds-icon-color
Jun 18, 2026
Merged

fix(base): revert ds-icon defining fill#5013
mimarz merged 2 commits into
mainfrom
fix-ds-icon-color

Conversation

@mimarz

@mimarz mimarz commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Not all icons are created equally, so it might be to opinionated for use to define fill for icons (svg).

Given an icon that is defined using lines (outline), defining fill on the svg breaks the icon. For example:

<svg
    xmlns="http://www.w3.org/2000/svg"
    width={size}
    height={size}
    fill="none"
    stroke="currentColor"
    strokeLinecap="round"
    strokeLinejoin="round"
    strokeWidth={2}
    viewBox="0 0 24 24"
    {...props}
  >
    <circle cx={6} cy={15} r={4} />
    <circle cx={18} cy={15} r={4} />
    <path d="M14 15a2 2 0 0 0-2-2 2 2 0 0 0-2 2M2.5 13 5 7c.7-1.3 1.4-2 3-2M21.5 13 19 7c-.7-1.3-1.5-2-3-2" />
  </svg>

https://designsystemet.slack.com/archives/C05RK9VEGJ0/p1781778192765679

@changeset-bot

changeset-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 968c8cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@digdir/designsystemet-css Patch
@digdir/designsystemet Patch
@digdir/designsystemet-types Patch
@digdir/designsystemet-react Patch
@digdir/designsystemet-web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mimarz mimarz changed the title fix(base): revert ds-icon defining fill fix(base): revert ds-icon defining fill Jun 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Preview deployments for this pull request:

storybook - 18. Jun 2026 - 12:55

@mimarz mimarz merged commit 9306bfd into main Jun 18, 2026
19 checks passed
@mimarz mimarz deleted the fix-ds-icon-color branch June 18, 2026 12:13
@github-actions github-actions Bot mentioned this pull request Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants