Skip to content

Say what a disconnect costs, where the choice is made #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
didriksg merged 1 commit into from
Sep 6, 2026
Merged

Say what a disconnect costs, where the choice is made #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Crisp/Resources/Localizable.xcstrings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,16 @@
"%lld%%" : {
"shouldTranslate" : false
},
"Stays disconnected until you reconnect it here." : {
"localizations" : {
"zh-Hans" : {
"stringUnit" : {
"state" : "translated",
"value" : "将保持断开，直到你在这里重新连接。"
}
}
}
},
"×" : {
"shouldTranslate" : false
},
Expand Down
11 changes: 11 additions & 0 deletions Crisp/Views/PhysicalDisplayToggleView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,17 @@ struct DisconnectDisplayRow: View {
}
}

// The disconnect outlives a replug and a reboot (see
// PhysicalDisplayToggleService.reconcile), and a display that is switched off
// at the window server shows no signal and is absent from System Settings, so
// there is nothing outside this menu to say what happened to it. Said here,
// where the choice is made, rather than left to be rediscovered later.
Text("Stays disconnected until you reconnect it here.")
.font(.caption)
.foregroundColor(.secondary)
.padding(.horizontal, 12)
.padding(.bottom, 4)

if let msg = errorMessage {
Text(msg)
.font(.caption)
Expand Down
Loading